- Issue created by @xem8vfdh
I'm not sure if this is related, but the module's test files live in
src/Tests/
, nottests/
- πΊπ¦Ukraine Taran2L Lviv
@xeM8VfDh, yes this is the reason (I believe)
- Status changed to Needs review
almost 2 years ago 1:10pm 11 April 2023 - πΊπ¦Ukraine Taran2L Lviv
Also, I've moved everything that is needed for tests to pass on D10
- π¨πSwitzerland salvis
Given that π Automated Drupal 10 compatibility fixes Fixed is green, is this needed at all?
Hey @salvis. The test is green there only for D9. Given your latest comment there, we could attempt the test runner on D8. Staging a test running using D10 fails to actually execute any tests, despite building successfully (example). @Taran2L thinks its because the tests are not in the standard
tests/
root directory. I am not sure myself, but that was my first suspicion as well.- last update
almost 2 years ago Patch Failed to Apply - Status changed to Needs work
almost 2 years ago 12:45am 17 April 2023 - π¨πSwitzerland salvis
Now this needs a re-roll, after π Automated Drupal 10 compatibility fixes Fixed has landed.
I wonder whether the tests will still work after this change. Maybe it's time for a new branch...
@salvis, here's my attempt at re-rolling based on these instructions β . let me know.
- last update
almost 2 years ago 5 pass - last update
almost 2 years ago 5 pass - Open on Drupal.org βCore: 10.0.7 + Environment: PHP 8.1 & MariaDB 10.3.22last update
almost 2 years ago Waiting for branch to pass @salvis, it looks like the re-roll is working across D9 and D10 βοΈ :)
Maybe you can merge into dev and execute the test runner against D8 there, as you did here π Automated Drupal 10 compatibility fixes Fixed .
-
salvis β
committed fe653a93 on 8.x-1.x
Issue #3351419 by Taran2L, xeM8VfDh, salvis: ACL module tests are in...
-
salvis β
committed fe653a93 on 8.x-1.x
- Status changed to Fixed
almost 2 years ago 9:38pm 17 April 2023 - π¨πSwitzerland salvis
Thank you for the patch, Taran2L, and for re-rolling, xeM8VfDh!
I was skeptical about being able to get this passed in D8, but it worked!
Automatically closed - issue fixed for 2 weeks with no activity.