Drupal 10 compatibility

Created on 29 March 2023, over 1 year ago
Updated 15 November 2023, about 1 year ago

Problem/Motivation

Trying to get this module running for Drupal 10

Steps to reproduce

Just install this module with some changes, you will get an error

Proposed resolution

Make it compatible with Drupal 10.

Need community support to test and report any other bug if any.

💬 Support request
Status

Fixed

Version

1.0

Component

Code

Created by

🇵🇰Pakistan hmdnawaz

Live updates comments and jobs are added and updated live.
Sign in to follow issues

Comments & Activities

  • Issue created by @hmdnawaz
  • Status changed to Needs review over 1 year ago
  • 🇩🇪Germany Anybody Porta Westfalica

    Drupal 10 EOL is close, any maintainer plans?

  • Status changed to RTBC about 1 year ago
  • 🇪🇸Spain manuel garcia

    Here are the results of running the upgrade status tool on the project:

    $ drush us-a jquery_countdown_timer
     [notice] Processing /var/www/html/web/modules/contrib/jquery_countdown_timer.
    
    ================================================================================
    jQuery Countdown Timer,  8.x-1.3
    Scanned on Fri, 10/20/2023 - 09:33
    
    FILE:
    web/modules/contrib/jquery_countdown_timer/jquery_countdown_timer.libraries.yml
    
    STATUS         LINE                           MESSAGE                           
    --------------------------------------------------------------------------------
    Check manually 0    The 'countdown.timer' library is depending on a deprecated  
                        library. The core/jquery.once asset library is deprecated in
                        Drupal 9.3.0 and will be removed in Drupal 10.0.0. Use the  
                        core/once library instead. See                              
                        https://www.drupal.org/node/3158256                         
    --------------------------------------------------------------------------------
    
    FILE: web/modules/contrib/jquery_countdown_timer/jquery_countdown_timer.info.yml
    
    STATUS         LINE                           MESSAGE                           
    --------------------------------------------------------------------------------
    Check manually 0    Value of core_version_requirement: ^8 || ^9 is not          
                        compatible with the next major version of Drupal core. See  
                        https://drupal.org/node/3070687.                            
    --------------------------------------------------------------------------------
    
    FILE: web/modules/contrib/jquery_countdown_timer/composer.json
    
    STATUS         LINE                           MESSAGE                           
    --------------------------------------------------------------------------------
    Check manually 0    The drupal/core requirement is not compatible with the next 
                        major version of Drupal. Either remove it or update it to be
                        compatible. See                                             
                        https://drupal.org/node/2514612#s-drupal-9-compatibility.   
    --------------------------------------------------------------------------------

    All points picked up by the upgrade_status analisys tool have been addressed in the latest patch.

    I have also gone over the changes on jquery_countdown_timer_init.js (which isn't picked up by the tool), they make sense and there is no other adjustments that we need to make there as far as I can see. To me the patch looks good to go so I am RTBCing.

    Drupal 9 EOL is November 1st, which is just around the corner, it would be nice if we can get this in and cut a new release :)

  • Status changed to Fixed about 1 year ago
  • Automatically closed - issue fixed for 2 weeks with no activity.

Production build 0.71.5 2024