- Issue created by @afagioli
- Status changed to Fixed
over 1 year ago 7:49pm 28 March 2023 Automatically closed - issue fixed for 2 weeks with no activity.
- Status changed to Fixed
over 1 year ago 7:27am 26 July 2023 - 🇬🇧United Kingdom Alina Basarabeanu
Can we have this change deployed as a new stable version? Currently, the 8.x-2.1-alpha1 version is not working and the module can't be used.
- 🇬🇧United Kingdom Alina Basarabeanu
For now, I've created a patch to fix the error across the sub-modules.
- 🇬🇧United Kingdom Alina Basarabeanu
Hi @afagioli
Why was this ticket closed when there is no new stable version for this module?
I've tried to upgrade bat_api to the latest version but the functionality breaks because there is missing functionality for the bat module. - Merge request !4Issue #3350936: Function bat_type_load renamed in bat_unit_type_load → (Open) created by Alina Basarabeanu
- 🇬🇧United Kingdom Alina Basarabeanu
This patch was not fully merged into the 8.x-3.x-dev branch.
The fix for the BatEventUIController class is still missing. - Status changed to Needs work
about 1 year ago 9:25am 3 November 2023 - 🇮🇹Italy afagioli Rome
Function
bat_unit_type_load
exists insidebat_unit.module
a@silver:~/drupal.org/bat/modules/bat_unit$ git status On branch 8.x-9.x Your branch is up-to-date with 'origin/8.x-9.x'. nothing to commit, working tree clean a@silver:~/drupal.org/bat/modules/bat_unit$ grep -r 'function bat_unit_type_load' * bat_unit.module:function bat_unit_type_load($type_id, $reset = FALSE) { bat_unit.module:function bat_unit_type_load_multiple(array $type_ids, array $conditions, $reset = FALSE) { a@silver:~/drupal.org/bat/modules/bat_unit$
- Status changed to Needs review
about 1 year ago 9:42am 3 November 2023 - First commit to issue fork.
- 🇪🇸Spain Carlitus
With the 2.1 version this happens yet, and the patch of #10 doesn't work for me.
I've made a change in the MR but it wanted to put in the 2.x version and i don't know how to change, or if tis possible.
I've made a new patch instead.
- 🇫🇮Finland jwwj
Patch in #16 seems to apply OK for me on Drupal 10 and 2.1 version
- Status changed to RTBC
about 1 year ago 7:23pm 29 November 2023 - 🇧🇪Belgium detroz
Even with the patch #16, I had a lot of problems with the version 8.x-2.1 of BAT module : functions not found, accessCheck() missing on queries, "FALSE" instead of "false" in js files, ... and a very unexpected behavior : impossible to upload or see new images.
There is my patch to solve all this things.
- Status changed to Needs work
about 1 year ago 12:24pm 15 December 2023 - 🇮🇹Italy afagioli Rome
Patch not applying, unfortunately.
Surely evaluating code in it.
Thank for contributing so far -
afagioli →
committed c35d280d on 8.x-10.x
#3350936 replace bat_type_load with bat_unit_type_load
-
afagioli →
committed c35d280d on 8.x-10.x
- 🇮🇹Italy afagioli Rome
To be noted patch in #22 is facing this tricky issue https://www.drupal.org/project/coding_standards/issues/3259288 → also
-
afagioli →
committed 83347f13 on 8.x-9.x
review and apply #3350936#comment-15362269
-
afagioli →
committed 83347f13 on 8.x-9.x
- Status changed to Needs review
about 1 year ago 9:05pm 16 December 2023 - 🇮🇹Italy afagioli Rome
- Status changed to Closed: outdated
9 months ago 7:32am 3 April 2024