- Issue created by @the_g_bomb
- @the_g_bomb opened merge request.
- Status changed to Needs review
over 1 year ago 1:44am 28 April 2023 - @the_g_bomb opened merge request.
- π¬π§United Kingdom the_g_bomb
I struggled rebasing the recent changes to the 2.x branch into the branch I had created initially, too many changes etc. So, I ended up closing the original MR and opening a new one.
I have nearly all the modules from the D7 version in this branch with the exception of 6 which arenβt available to D8/9/10 yet, and a further 7 which are no longer needed. They are outlined in the issue about splitting guardr_core: π Split Guardr into Guardr Core, Guardr Audit, Guardr Extras Needs review
- π¬π§United Kingdom the_g_bomb
I am now struggling to get guardr_core D10 installed on a project,
I suspect that the lenient allow list doesn't cascade down through the composer dependencies.
I may have to add the various patch forks to get the D10 versions of the modules that don't have a valid release available yet.
- Merge request !14Issue #3350324: Update the composer file to include the Drupal 10 compatible modules β (Open) created by the_g_bomb
- π¬π§United Kingdom the_g_bomb
MR 14 can be tested using:
composer create-project --no-interaction --no-install drupal/recommended-project:^10.0 guardrd10test cd guardrd10test composer config repositories.guardr_core vcs git@git.drupal.org:issue/guardr_core-3350324.git composer require -W drupal/guardr_core:dev-3350324-update-to-D10-minimal
- π¬π§United Kingdom the_g_bomb
Still hoping these get merged:
email_confirmer - β¨ Drupal 10 compatibility Fixed
hacked - π Upgrade code to Drupal 10 Fixed
logging_alerts - π User deprecated function: Theme functions are deprecated in drupal:8.0.0 and are removed from drupal:10.0.0. Use Twig templates instead of theme_emaillog_admin_settings() RTBC
paranoia - π Automated Drupal 10 compatibility fixes Fixed
role_watchdog - π Automated Drupal 10 compatibility fixes Fixed
state_log - π Automated Drupal 10 compatibility fixes Fixed
view_profiles_perms - π Automated Drupal 10 compatibility fixes Fixed - First commit to issue fork.
- @joestewart opened merge request.
- πΊπΈUnited States joestewart
Hi Gareth, thank you for the issue and work!
I created a more minimal MR that didn't add any packages from the Guardr profile.
@Shrop and @Gareth does https://git.drupalcode.org/project/guardr_core/-/merge_requests/15 suffice for Drupal 10?
- πΊπΈUnited States shrop
Thanks Joe and Gareth!
I like this and noting we did remove Hacked in this discussion. I think once we have the D10 version released, we can look at the other items around splitting things up more and some other upcoming changes.
I am also thinking we should do Drupal core reqs like this - ^9.3 || ^10 vs. ^9 || ^10 could protect us from dependencies requiring 9.3. We have some now.
-
shrop β
committed dd4d81c0 on 2.x authored by
joestewart β
Issue #3350324 Drupal 10 compatible versions
-
shrop β
committed dd4d81c0 on 2.x authored by
joestewart β
- Status changed to Fixed
over 1 year ago 3:06pm 24 May 2023 - πΊπΈUnited States shrop
Thank to the team here! Great to get this going and talk next steps.
Guardr Core 2.1.0 β released.
Automatically closed - issue fixed for 2 weeks with no activity.