LinkitFilterEntityTest::testFilterEntityTranslations() does not test what it appears to test

+++ b/tests/src/Kernel/AssertLinkitFilterTrait.php
@@ -38,6 +38,8 @@ trait AssertLinkitFilterTrait {
+    $canonical_url_aka_not_path_alias = '/entity_test_mul/manage/1';
+    $this->assertStringNotContainsString($canonical_url_aka_not_path_alias, $this->process($input, $langcode)->getProcessedText());

Even though the test appears to claim to be testing that the filter puts the correct alias in place during filtering … that's not actually happening! 😅

This is caused by

    if ($container->hasDefinition('path_alias.path_processor')) {
      // The alias-based processor requires the path_alias entity schema to be
      // installed, so we prevent it from being registered to the path processor
      // manager. We do this by removing the tags that the compiler pass looks
      // for. This means that the URL generator can safely be used within tests.
      $container->getDefinition('path_alias.path_processor')
        ->clearTag('path_processor_inbound')
        ->clearTag('path_processor_outbound');
    }

in \Drupal\KernelTests\KernelTestBase::register(), which has been in place since KernelTestBase was introduced in #2304461: KernelTestBaseTNG™ → !

The solution is simple: undo that, because it's an assumption that is not a problem for this particular test, since we do install path_alias' entity schema.

The last submitted patch, 2: 3350223-2-FAIL.patch, failed testing. View results →

Note that this bug has only remained hidden for all these years because too much in the test was generated/computed. With more explicit expectations defined, this could never have happened.

As part of working on ✨ Drastically improve the linking experience in CKEditor 5 Needs work , I was hardening the test coverage, and that's how I discovered this. See that MR for a comprehensive strengthening of this module's filter kernel test.

The last submitted patch, 3: 3350223-3.patch, failed testing. View results →

The failure is unrelated:

There was 1 failure:

1) Drupal\Tests\linkit\FunctionalJavascript\LinkitDialogCKEditor5Test::testLinkDialog
Failed asserting that a NULL is not empty.

The failure is unrelated:

I was getting a similar (but different assertion) false failure in https://www.drupal.org/project/linkit/issues/3232190#comment-14898179 📌 CKEditor 5 readiness Fixed

Assigning myself for review!

I just realized that's probably due to 📌 Update CKEditor 5 to 36.0.1 Fixed landing earlier today!

So, re-testing this against 10.0.x, then it should pass 🤓

Looks like my hunch was correct 🥳

In 10.0.7 CKEditor5 major upgrade to v36 has been now reverted .

// Undo what the parent did, to allow testing path aliases in kernel tests.

This comment clarifies what's going on here, so I think it's clear to our future selves why we're doing this :) . I also ran the tests against 9.5.x just to be sure after the 9.5.6/9.5.7 hullabaloo. Everything looks good!

Automatically closed - issue fixed for 2 weeks with no activity.