- Issue created by @huzooka
- @huzooka opened merge request.
- Issue was unassigned.
- Status changed to Needs review
almost 2 years ago 6:20pm 22 March 2023 - ππΊHungary huzooka Hungary ππΊπͺπΊ
Old-school patch attached.
- π¬π§United Kingdom jaydenpearly
I thought of applying the patch when it comes to the importantn issue and performance is concerned.
I actually have no idea about how it indexes or what it is :))
You probably know something. thanks. - π¬π§United Kingdom jaydenpearly
I've been using it for a while. I didn't have a problem. Of course, since I do not have a large amount of data during this time, I cannot test it.
My curiosity; Why was the patch on such an important issue not merched until now?
Do you think we should use this patch on a prodcution site? - πΊπΈUnited States tr Cascadia
Why has it not been merged? Because it is a patch proposed by one person and no one else has reviewed it to confirm it works. Because no one has written a test of the hook_update, and no one has written a test of the new storage class to confirm this patch works and doesn't break sites. We don't even have any benchmarking data to determine if this actually helps, or if it does help then how much.
I'm not going to casually commit a patch that modifies the database of everyone using Voting API without some automated tests and without some feedback from the community. This is just basic good practice, and is a requirement for Drupal core issues.
This may be a very useful patch, but so far no one has tried it out to confirm that. That's why the issue is still set to "Needs review".
- π¬π§United Kingdom jaydenpearly
Ok,I see. I'm new to the community. And I am just getting to know this working culture.
Thanks for your reply. - Status changed to RTBC
over 1 year ago 8:13pm 29 September 2023 - heddn Nicaragua
Tested the hook update and the indexes themselves. As mentioned in the OP, it doesn't help a lot for those of us with only a few thousand votes. My site has ~766K votes and ~3300 results. To manually calculate votes on 410 nodes for a total of 18K votes, with and without the patch it takes about ~19-20 seconds. But I imagine that is because there are only 3300 vote results in my DB. This proves that 1) performance doesn't suffer 2) the update hook is in a good state.
- Status changed to Needs work
over 1 year ago 6:49am 3 October 2023