- Issue created by @longwave
- Status changed to Needs review
over 1 year ago 5:29pm 22 March 2023 - Status changed to RTBC
over 1 year ago 6:49pm 22 March 2023 - πΊπΈUnited States smustgrave
This will be backported to the contrib too?
- π¦πΊAustralia larowlan π¦πΊπ.au GMT+10
I reran the build and didn't get the same result.
Here's the steps I took
# Commands run on local git clone git@github.com:ckeditor/ckeditor4.git cd ckeditor4 git checkout 4.21.0 cp /PATH/TO/CORE/core/assets/vendor/ckeditor/buid-config.js ./dev/builder docker run -v `pwd`:/data --rm -it openjdk:15 bash # Commands run inside docker container microdnf install bc git git config --global --add safe.directory /data ./dev/builder/build.sh # Commands run on local cd /PATH/TO/CORE/core/assets/vendor tar -xzvf /PATH/TO/ckeditor4/dev/builder/release/ckeditor_4.21.0.tar.gz cd /PATH/TO/CORE # Manually edit core/core.libraries.yml git add core/core.libraries.yml git add core/assets/vendor/ckeditor -f
What did I miss?
- Status changed to Needs review
over 1 year ago 10:44pm 22 March 2023 - π¦πΊAustralia larowlan π¦πΊπ.au GMT+10
Here's the interdiff between my 9.5 build and longwave's the 9.4 one is similar
- Status changed to RTBC
over 1 year ago 11:12pm 22 March 2023 - π¦πΊAustralia larowlan π¦πΊπ.au GMT+10
Ok, worked out the difference, the .tar.gz has all the plugins, the zip is your specific build.
After using that, or the release/ckeditor file I only get a different timestamp.
Going to commit this
I'll update the docs re where the 'release' actually is (ie its not the .tar.gz)
- π§πͺBelgium wim leers Ghent π§πͺπͺπΊ
larowlan β credited Wim Leers β .
-
larowlan β
committed 7d7a0614 on 9.4.x
Issue #3349691 by longwave, larowlan, Wim Leers, xjm, jbogdanski: Update...
-
larowlan β
committed 7d7a0614 on 9.4.x
-
larowlan β
committed b31be928 on 9.5.x
Issue #3349691 by longwave, larowlan, Wim Leers, xjm, jbogdanski: Update...
-
larowlan β
committed b31be928 on 9.5.x
- Status changed to Fixed
over 1 year ago 11:20pm 22 March 2023 - π¦πΊAustralia larowlan π¦πΊπ.au GMT+10
Committed to 9.5.x and 9.4.x and updated the ckeditor building docs β
Automatically closed - issue fixed for 2 weeks with no activity.