- Issue created by @dmundra
- πΊπΈUnited States dmundra Eugene, OR
Here is the patch that fixes the error for me. It replaces 'drupalSettings' with the regular convention 'Drupal.settings'.
- πΊπΈUnited States dmundra Eugene, OR
Noticed a small bug in my previous patch. Here is a new one.
- Status changed to Needs review
over 1 year ago 2:12pm 22 March 2023 - πΊπΈUnited States DamienMcKenna NH, USA
That seems like the correct approach - D7 uses Drupal.settings instead of drupalSettings.
- Status changed to RTBC
over 1 year ago 6:46pm 22 March 2023 - πΊπΈUnited States mglaman WI, USA
Oh jeez, thanks. That's a big whoopsie.
-
mglaman β
committed 72ea808a on 7.x-2.x authored by
dmundra β
Issue #3349458 by dmundra, DamienMcKenna: drupalSettings is not defined...
-
mglaman β
committed 72ea808a on 7.x-2.x authored by
dmundra β
- Status changed to Fixed
over 1 year ago 6:47pm 22 March 2023 - πΊπΈUnited States mglaman WI, USA
Thank you! Committed. I am waiting to release to review any other issues, I'll release next week.
- πΊπΈUnited States DamienMcKenna NH, USA
Thanks for the quick response, mglaman. I wonder might this have caused some of the other bugs people reported?
- πΊπΈUnited States dmundra Eugene, OR
Hey @mglaman, no worries and thank you for committing it.
Automatically closed - issue fixed for 2 weeks with no activity.
- Status changed to Fixed
over 1 year ago 2:08pm 18 April 2023 - πΊπΈUnited States ohanm
Hi mglaman, if I undertsand #7 correctly, will there be another release?
- πΊπΈUnited States mglaman WI, USA
Ah sorry, I thought I did. I made a task for myself. Sorry!
- πΊπΈUnited States mglaman WI, USA