Call getMainRequest() instead getMasterRequest

Created on 21 March 2023, over 1 year ago
Updated 30 August 2023, over 1 year ago

Problem/Motivation

Steps to reproduce

Proposed resolution

Remaining tasks

User interface changes

API changes

Data model changes

🐛 Bug report
Status

Fixed

Version

1.0

Component

Code

Created by

🇺🇦Ukraine Vasyl Vasylkiv

Live updates comments and jobs are added and updated live.
Sign in to follow issues

Comments & Activities

  • Issue created by @Vasyl Vasylkiv
  • @vasyl-vasylkiv opened merge request.
  • Issue was unassigned.
  • Status changed to Needs review over 1 year ago
  • 🇮🇳India Ranjit1032002

    MR!7 looks good and working as expected.

  • First commit to issue fork.
  • @hmdnawaz opened merge request.
  • 🇵🇰Pakistan hmdnawaz

    We should Drupal\Core\Http\RequestStack instead of the Symfony\Component\HttpFoundation\RequestStack according to the

    Symfony\Component\HttpFoundation\RequestStack::getMasterRequest() is deprecated in drupal:9.3.0 and is removed from drupal:10.0.0 for Symfony 6 compatibility. Use the forward compatibility shim class Drupal\Core\Http\RequestStack and its getMainRequest() method instead.

    MR#8 doest that

  • 🇧🇷Brazil sophiavs

    Hi, i tried testing the MR#8, but since the parameter was changed it should also be changed in SessionBasedTempStoreFactory.php and when I tried to change there too the dependency injection was returning a error.

    I tried with the MR#7 and it works just as expected! i created a patch to be possible to use while this isn't merged.

  • Status changed to Fixed over 1 year ago
  • 🇷🇺Russia nortmas Crimea/Thailand

    Thanks. Fixed in a new version.

  • Automatically closed - issue fixed for 2 weeks with no activity.

Production build 0.71.5 2024