- 🇮🇹Italy apaderno Brescia, 🇮🇹
The issue summary should always describe what should be fixed/changed. The title is not sufficient to describe what the issue is, even in the case a patch is provided.
- Status changed to Needs review
over 1 year ago 12:42pm 21 March 2023 - 🇮🇳India urvashi_vora Madhya Pradesh, India
Hi @apaderno,
I have updated the issue summary.
- Status changed to Needs work
over 1 year ago 12:47pm 21 March 2023 - 🇮🇳India urvashi_vora Madhya Pradesh, India
Hi @gayatri chahar,
I reviewed your patch, it was applied cleanly.
<strong>git apply -v 3349273-2.patch</strong> Checking patch entity_translations_helper.module... Applied patch entity_translations_helper.module cleanly.
IMHO, we should keep the help function at the end of file, thus, moving it to needs work.
Thanks for the work.
- Status changed to Needs review
over 1 year ago 12:50pm 21 March 2023 - 🇮🇳India urvashi_vora Madhya Pradesh, India
Hi,
I have added the help function at the end of file.
Please review the patch and also providing an interdiff.
Thanks
- Status changed to RTBC
over 1 year ago 2:41am 22 March 2023 - 🇵🇭Philippines paraderojether
Hi @urvashi_vora
I applied patch #7 against Entity translations helper version 1.0.x-dev with Drupal core version 9.5.3, confirmed help function is added at the end of file, and the patch works fine for me.
I added screenshots for reference.
Thank You.