Fieldset elements with #description_display set as before are outputted as a prefix

This patch removes the @todo code.

The last submitted patch, 2: fieldset-description-display-3349222-2.patch, failed testing. View results →

Looks good! Attaching screenshot.

Automatically closed - issue fixed for 2 weeks with no activity.

This fix works for me for text fields, but for select lists in a fieldset, the description still goes to the bottom. Screenshot attached.

Can confirm that this still happens when items are wrapped in a fieldset.
For example, the Webform Scale-element.

I'm not sure how to fix this.

What we're doing for a work around on this is using an HTML field and not using the description field on field sets. It's not ideal, but it works for now.

This issue still exist when items are wrapped in the fieldset.

The only way to fix this was use `template_preprocess_fieldset()` in the custom theme and set `description_display` value (before/after).

For folks still seeing the description appear at the end of the fieldset despite setting it to "before," check your theme to determine if it’s checking for description_display. Mine wasn’t. I copied the relevant code from my theme’s base theme (stable9 at core/themes/stable9/form/fieldset.html.twig) which uses the following structure:

<div class="fieldset-wrapper">
    {% if description_display == 'before' and description.content %}
      <div{{ description.attributes.addClass('description') }}>{{ description.content }}</div>
    {% endif %}
    {% if errors %}
      <div>
        {{ errors }}
      </div>
    {% endif %}
    {% if prefix %}
      <span class="field-prefix">{{ prefix }}</span>
    {% endif %}
    {{ children }}
    {% if suffix %}
      <span class="field-suffix">{{ suffix }}</span>
    {% endif %}
    {% if description_display in ['after', 'invisible'] and description.content %}
      <div{{ description.attributes.addClass('description') }}>{{ description.content }}</div>
    {% endif %}
  </div>
</fieldset>

@helianthropy, Thanks for posting that! A quick fix.