Deprecate drupal_theme_rebuild()

Deprecation and test

CR https://www.drupal.org/node/3348853 →

replace usage, not sure about removal of protected method as BC but now it needs to try inject registry

The last submitted patch, 2: 3348851-2.patch, failed testing. View results →

All code changes look good to me.
Deprecation message testing has been added.
The testbot return green.
The IS and the CR are in order.
For me it is RTBC.

The last submitted patch, 5: 3348851-3.patch, failed testing. View results →

re-queued as can't reproduce locally

Drupal\Tests\user\Kernel\Migrate\MigrateUserStubTest

fail: [Other] Line 0 of sites/default/files/simpletest/phpunit-1178.xml:
PHPUnit Test failed to complete; Error: PHPUnit 9.5.28 by Sebastian Bergmann and contributors.

Testing Drupal\Tests\user\Kernel\Migrate\MigrateUserStubTest
F                                                                   1 / 1 (100%)

Time: 00:01.528, Memory: 4.00 MB

There was 1 failure:

1) Drupal\Tests\user\Kernel\Migrate\MigrateUserStubTest::testStub
Failed asserting that an object is empty.

/var/www/html/vendor/phpunit/phpunit/src/Framework/Constraint/Constraint.php:122
/var/www/html/vendor/phpunit/phpunit/src/Framework/Constraint/Constraint.php:55
/var/www/html/core/modules/migrate_drupal/src/Tests/StubTestTrait.php:22
/var/www/html/core/modules/user/tests/src/Kernel/Migrate/MigrateUserStubTest.php:35
/var/www/html/vendor/phpunit/phpunit/src/Framework/TestResult.php:728

FAILURES!
Tests: 1, Assertions: 8, Failures: 1.

Applying the 3348851-3 patch produced the following results.

$ git branch
* 10.1.x

Before patch was applied

$  git grep drupal_theme_rebuild                                                                    
core/includes/theme.inc:function drupal_theme_rebuild() {
core/lib/Drupal/Core/Extension/ModuleInstaller.php:        drupal_theme_rebuild();
core/lib/Drupal/Core/Extension/ModuleInstaller.php:      drupal_theme_rebuild();
core/lib/Drupal/Core/Extension/ThemeInstaller.php:   * Wraps drupal_theme_rebuild().
core/lib/Drupal/Core/Extension/ThemeInstaller.php:    drupal_theme_rebuild();
core/modules/image/src/Entity/ImageStyle.php:    drupal_theme_rebuild();
core/modules/system/tests/modules/theme_test/src/EventSubscriber/ThemeTestSubscriber.php:      drupal_theme_rebuild();
core/modules/system/tests/src/Functional/Theme/ThemeTest.php:    drupal_theme_rebuild();
core/modules/system/tests/src/Functional/Theme/ThemeTest.php:    drupal_theme_rebuild();

After patch was applied

$  git grep drupal_theme_rebuild 
includes/theme.inc:function drupal_theme_rebuild() {
tests/Drupal/KernelTests/Core/Theme/RegistryTest.php:   * Tests deprecated drupal_theme_rebuild() function.
tests/Drupal/KernelTests/Core/Theme/RegistryTest.php:   * @see drupal_theme_rebuild()
tests/Drupal/KernelTests/Core/Theme/RegistryTest.php:    $this->expectDeprecation('drupal_theme_rebuild() is deprecated in drupal:10.1.0 and is removed from drupal:11.0.0. Use theme.registry service reset() method instead. See https://www.drupal.org/node/3348853');
tests/Drupal/KernelTests/Core/Theme/RegistryTest.php:    drupal_theme_rebuild();

PHPUnit test result

$ ../vendor/bin/phpunit --filter testLegacyThemeRegistryRebuild ./tests/Drupal/KernelTests/Core/Theme/RegistryTest.php

PHPUnit 9.6.5 by Sebastian Bergmann and contributors.

Testing Drupal\KernelTests\Core\Theme\RegistryTest
.                                                                   1 / 1 (100%)

Time: 00:01.667, Memory: 8.00 MB

OK (1 test, 3 assertions)

Committed 8184e39 and pushed to 10.1.x. Thanks!

Filed follow-up 📌 Properly inject the theme registry in the ThemeInstaller Fixed

Automatically closed - issue fixed for 2 weeks with no activity.