- Issue created by @Xiaohua Guan
- @xiaohua-guan opened merge request.
- Status changed to Needs review
over 1 year ago 9:27am 18 March 2023 - Status changed to Needs work
over 1 year ago 7:24am 20 March 2023 - 🇺🇸United States yas California 🇺🇸
@xiaohua-guan
Can you please rebase the patch due to the previous merge? Thanks!
- Status changed to Needs review
over 1 year ago 11:40am 20 March 2023 - 🇺🇸United States yas California 🇺🇸
@xiaohua-guan
Thank you for the update. I ran the BDD tests and it worked fine. The patch looks good.
@sekinet @tamakifujino
What do you think?
Thanks
- Status changed to RTBC
over 1 year ago 7:01am 21 March 2023 - 🇺🇸United States TamakiFujino
@yas @xiaohua-guan it looks good to me. I will change the file name number of other BDD test scenarios later.
- 🇺🇸United States yas California 🇺🇸
@tamakifujino @sekinet
Thank you for your review. I'll merge the patch to
4.xand5.x, and close this issue as Fixed. - Status changed to Needs work
over 1 year ago 9:02am 21 March 2023 - 🇺🇸United States yas California 🇺🇸
@xiaohua-guan
Can you please rebase the patch? Thanks
- Status changed to Needs review
over 1 year ago 11:11am 21 March 2023 - 🇯🇵Japan Xiaohua Guan Tokyo, Japan
@yas
I rebased it. Please check it again.
- Status changed to RTBC
over 1 year ago 7:29pm 21 March 2023 - 🇺🇸United States yas California 🇺🇸
@xiaohua-guan
Thank you for the update. I'll merge the patch to
4.xand5.x, and close this issue as Fixed. -
yas →
committed eaf701ac on 5.x authored by
Xiaohua Guan →
Issue #3348833 by Xiaohua Guan, yas, TamakiFujino, sekinet: Refactor...
-
yas →
committed eaf701ac on 5.x authored by
Xiaohua Guan →
-
yas →
committed 21aaa54d on 4.x authored by
Xiaohua Guan →
Issue #3348833 by Xiaohua Guan, yas, TamakiFujino, sekinet: Refactor...
-
yas →
committed 21aaa54d on 4.x authored by
Xiaohua Guan →
- Status changed to Fixed
over 1 year ago 8:33pm 21 March 2023 Automatically closed - issue fixed for 2 weeks with no activity.