Switch to using AutoUpdate's approach to running core checks

Created on 17 March 2023, over 1 year ago
Updated 13 October 2023, about 1 year ago

Problem/Motivation

As seen within πŸ“Œ Update to Package Manager 3.x Fixed , there is a much less brittle approach to running commit checks

Steps to reproduce

Proposed resolution

Remaining tasks

  • βœ… File an issue about this project
  • ☐ Manual Testing
  • ☐ Code Review
  • ☐ Accessibility Review
  • ☐ Automated tests needed/written?
πŸ“Œ Task
Status

Closed: outdated

Version

1.0

Component

Code

Created by

πŸ‡ΊπŸ‡ΈUnited States tim.plunkett Philadelphia

Live updates comments and jobs are added and updated live.
Sign in to follow issues

Comments & Activities

Not all content is available!

It's likely this issue predates Contrib.social: some issue and comment data are missing.

  • Issue created by @tim.plunkett
  • @timplunkett opened merge request.
  • First commit to issue fork.
  • Status changed to Needs review over 1 year ago
  • πŸ‡ΊπŸ‡ΈUnited States tim.plunkett Philadelphia
  • πŸ‡ΊπŸ‡ΈUnited States chrisfromredfin Portland, Maine

    Woo! Linting & testing back up and working.

  • Status changed to Fixed over 1 year ago
  • Status changed to Needs work over 1 year ago
  • πŸ‡§πŸ‡ͺBelgium wim leers Ghent πŸ‡§πŸ‡ͺπŸ‡ͺπŸ‡Ί

    I introduced this alternative approach for Package Manager/Automatic Updates in πŸ“Œ Stop reusing core's commit-code-check.sh in favor of 4 simple commands Fixed . But there's one important difference between the two projects: PM/AU does not contain any JS, but PB does!

    So right now you lost all JS code quality checks πŸ˜… You'll want to port those over.

  • πŸ‡ΊπŸ‡ΈUnited States tim.plunkett Philadelphia

    Good point @Wim Leers!

    But I think we only have one non-Svelte JS file, and we were already going out of our way to disable JS checks for those, since they contain HTML and CSS as well.

    That's why our version committed above has an additional step to run our lint:svelte command

    I'll leave this for @chrisfromredfin to ponder, but I think we're okay here

  • πŸ‡ΊπŸ‡ΈUnited States chrisfromredfin Portland, Maine

    As I've thought about this, it feels the same as the yaml linter. We could do it now or do it later, but the consequence regardless is minimal. If we discover it late, it's maybe 30 minutes to fix both, because the surface area is so small. It might be nice to open a lower-priority ticket to add those two things.

    My larger concern is that the javascript that IS inside of .svelte files is passing Drupal JS checks, and I'm hoping lint:svelte is able to check those things.

  • Status changed to Closed: outdated about 1 year ago
  • πŸ‡ΊπŸ‡ΈUnited States chrisfromredfin Portland, Maine

    Documenting here that yes, lint:svelte does check for proper formatting inside of the .svelte files, so I do think we're good here.

Production build 0.71.5 2024