- Issue created by @tim.plunkett
- @timplunkett opened merge request.
- First commit to issue fork.
- Status changed to Needs review
over 1 year ago 5:28pm 18 March 2023 - πΊπΈUnited States chrisfromredfin Portland, Maine
Woo! Linting & testing back up and working.
- Status changed to Fixed
over 1 year ago 6:13pm 18 March 2023 -
chrisfromredfin β
committed 39ee0fbf on 1.0.x authored by
tim.plunkett β
Issue #3348781 by tim.plunkett, chrisfromredfin: Switch to using...
-
chrisfromredfin β
committed 39ee0fbf on 1.0.x authored by
tim.plunkett β
- Status changed to Needs work
over 1 year ago 8:52am 20 March 2023 - π§πͺBelgium wim leers Ghent π§πͺπͺπΊ
I introduced this alternative approach for Package Manager/Automatic Updates in π Stop reusing core's commit-code-check.sh in favor of 4 simple commands Fixed . But there's one important difference between the two projects: PM/AU does not contain any JS, but PB does!
So right now you lost all JS code quality checks π You'll want to port those over.
- πΊπΈUnited States tim.plunkett Philadelphia
Good point @Wim Leers!
But I think we only have one non-Svelte JS file, and we were already going out of our way to disable JS checks for those, since they contain HTML and CSS as well.
That's why our version committed above has an additional step to run our
lint:svelte
commandI'll leave this for @chrisfromredfin to ponder, but I think we're okay here
- πΊπΈUnited States chrisfromredfin Portland, Maine
As I've thought about this, it feels the same as the yaml linter. We could do it now or do it later, but the consequence regardless is minimal. If we discover it late, it's maybe 30 minutes to fix both, because the surface area is so small. It might be nice to open a lower-priority ticket to add those two things.
My larger concern is that the javascript that IS inside of .svelte files is passing Drupal JS checks, and I'm hoping lint:svelte is able to check those things.
- Status changed to Closed: outdated
about 1 year ago 8:12am 13 October 2023 - πΊπΈUnited States chrisfromredfin Portland, Maine
Documenting here that yes, lint:svelte does check for proper formatting inside of the .svelte files, so I do think we're good here.