Update to Package Manager 3.x

All of the

Error: Class "Symfony\Component\Config\Resource\ClassExistenceResource" not found

errors are related to autowiring.

Should probably autowire all services see 📌 Autowire everything everywhere all at once … in *.services.yml files Fixed for example

kunal.sachdev → made their first commit to this issue’s fork.

Reverting autowire because we saw a weird behaviour with package_manager_bypass which wan't mocking package_manager.committer anymore hence we decided to tackle the whole autowiring later.

I spotted one problem and tried to fix it, and then I thought I had another fix but it's still all stuck on ClassExistenceResource problems. I'm fully out of my depth here, passing back to the AU team

Also, I started pulling out 📌 Switch to using AutoUpdate's approach to running core checks Closed: outdated from this issue

Postponed on 📌 Switch to using AutoUpdate's approach to running core checks Closed: outdated .

That landed

I am 10000% certain that @tim.plunkett wouldn't mind @kunal.sachdev & @omkar.podey pushing this forward while he's still sleeping 😄😴

Left an initial review. But before that needs to be addressed, we should first get this to green, i.e. passing phpstan!

tim.plunkett → credited chrisfromredfin → .

Resolved the errors, and half of Wim's feedback. Anyone should feel free to fix remaining unresolved threads

I have a question, as far as I know Automatic Updates 3.0.x branch supports Drupal ^10.1, then why are we still trying to support Drupal ^10.0.1 in project browser since it depends on package manager anyways ?

That's a good question!
The answer is because Project Browser does not depend on Package Manager directly. It provides it's own functionality, but it is enhanced when Package Manager is installed.
And because we want to continue having as many people test the module as possible, we want to keep supporting 10.0.x

I see, which also explains why we don't add package_manager as a dependency , thanks for the speedy response 😁

This should be good to go. Anyone want to give it a final review?

Will do.

@phenaproxima You're still awake?! 🤯

I had a short bout of wakefulness. Don't worry, I didn't do any actual reviewing.

Looks pretty good. Couple of tiny spelling errors (which makes me wonder why cspell didn't kick in), and one question.

All feedback addressed, passing on 10.1 and 10.0!

🚢 👍 🚀

Woooooo!

Thanks for spearheading this tim & adam, excellent collaboration, and for everyone else's work.

I was surprised to see the roughly 50/50 diffstat … that could not possibly be right! 🤓

And turns out my hunch was right: thanks to adopting Package Manager's FixtureManipulator, the JSON fixtures are now unused: let's delete them!

Oh wonderful, thanks @Wim Leers! Committed that directly

Automatically closed - issue fixed for 2 weeks with no activity.