- Issue created by @wim leers
- @wim-leers opened merge request.
- Status changed to Needs work
over 1 year ago 12:00pm 16 March 2023 - 🇧🇪Belgium wim leers Ghent 🇧🇪🇪🇺
The 2 commits I pushed add the necessary validation.
- Assigned to kunal.sachdev
- 🇺🇸United States phenaproxima Massachusetts
Wim Leers → credited phenaproxima → .
- 🇧🇪Belgium wim leers Ghent 🇧🇪🇪🇺
Responded to @phenaproxima's review. Crediting him for that review too.
- Issue was unassigned.
- Status changed to Needs review
over 1 year ago 8:48am 23 March 2023 - Assigned to kunal.sachdev
- Status changed to Needs work
over 1 year ago 12:37pm 31 March 2023 - 🇺🇸United States phenaproxima Massachusetts
This is pretty straightforward. One change seems questionable, so that's blocking; most of my other comments are just recommendations to use first-class callable syntax for brevity.
- Issue was unassigned.
- Status changed to Needs review
over 1 year ago 8:28am 3 April 2023 - Status changed to RTBC
over 1 year ago 3:51pm 3 April 2023 - 🇺🇸United States phenaproxima Massachusetts
I'm happy with this. Great work, @kunal.sachdev!
-
phenaproxima →
committed 6f67db84 on 3.0.x authored by
Wim Leers →
Issue #3348441 by kunal.sachdev, phenaproxima, Wim Leers: Many callers...
-
phenaproxima →
committed 6f67db84 on 3.0.x authored by
Wim Leers →
- Status changed to Fixed
over 1 year ago 4:34pm 17 April 2023 Automatically closed - issue fixed for 2 weeks with no activity.
