Ensure all remaining @todos have a link to an open issue

Removing the list item for SymlinkValidator, because 📌 Add symlink support to Composer Stager 2.0, require that version, and simplify UX & tests accordingly Fixed fulfills and removes the todo.

Created 🐛 In CoreUpdateTest::testUi, confirm that the UI says no update is available after updating successfully Fixed to get rid of todo in \Drupal\Tests\automatic_updates\Build\CoreUpdateTest::assertUpdateSuccessful() hopefully a quick fix 🤞🏻

fixed [#assertUpdateSuccessful]

So \Drupal\Tests\automatic_updates\Build\CoreUpdateTest::assertUpdateSuccessful() is removed

1. I think we should just remove the todo in CorePackageManifestTest and remove the package_manager/core_packages.yml unless we have reason that others would need this list. As far as I know nobody else has suggested they need this list. I just to moved the list directly into \Drupal\package_manager\InstalledPackagesList::getCorePackageList as that is the only place we need it.

   If we move the list somewhere central in core this effectively would become an API. We can also create a central list of core packages later.

   UPDATE: I just realized we lost test coverage in \Drupal\Tests\package_manager\Kernel\CorePackageManifestTest::testCorePackagesMatchManifest

   I guess if others agree with my change we should open up another issue remove the list like I did here: https://git.drupalcode.org/project/automatic_updates/-/merge_requests/78...

   but also update \Drupal\Tests\package_manager\Unit\InstalledPackagesListTest::testCorePackages to ensure that all packages in core directory are present. We have the logic here now \Drupal\Tests\package_manager\Kernel\CorePackageManifestTest::testCorePackagesMatchManifest

2. I removed the todo in UpdaterForm::createReleaseTable() I originally put that comment in. I checked and there is no Update module template to use.

Assigning to @Wim Leers to review especially my idea to remove the core_packages.yml

+1 on removing core_packages.yml.

I've been wanting to remove core_packages.yml for a long time 😄

Following todos have invalid issue links :

1. automatic_updates.module : line 166 // @todo Refactor this after https://www.drupal.org/project/drupal/issues/2969056
2. PackageManagerServiceProvider.php : line 18 * @todo Refactor this if/when symfony/config becomes a dependency: revert https://www.drupal.org/i/3345039.
3. TemplateProjectTestBase.php : line 520
   

   // @todo Find a better solution than a view that could change to ensure
         //   ensure these events have fired in https://drupal.org/i/3319768.

4. CronUpdater.php : line 228
   

   // @todo If using the built-in PHP web server, validate that this port is
       //   set in https://www.drupal.org/i/3293146.

5. ConfigSubscriber.php : line 17
   

    * @todo Move this functionality into StatusChecker when
    *   https://www.drupal.org/i/3275317#comment-14482995 is resolved.

6. automatic_updates_test_cron.module : line 7
   

    * @todo Move into automatic_updates when TUF integration is stable in
    *   https://www.drupal.org/i/3322361.

7. ComposerInspector.php : line 270 // @todo Remove this once https://github.com/composer/composer/issues/11302 lands and ships in a composer release.
8. UpdateReleaseValidator.php : line 23 * @todo Remove this validator completely in https://www.drupal.org/i/3307369.
9. BatchProcessor.php : line 120
   

   // @todo See if there's a better way to ensure the post-apply tasks run
         //   in a new request in https://www.drupal.org/i/3293150.

This todo doesn't point to a issue link

10. UpdaterFormNoRecommendedReleaseMessageTest.php : line 94

    // @todo Use \Drupal\Tests\WebAssert::statusMessageContains() when module
        //   drops support for Drupal core 9.3.x.

Following remaining todos have invalid issue links :

1. ConfigSubscriber.php : line 17
   

    * @todo Move this functionality into StatusChecker when
    *   https://www.drupal.org/i/3275317#comment-14482995 is resolved.

2. UpdateReleaseValidator.php : line 23 * @todo Remove this validator completely in https://www.drupal.org/i/3307369.
3. This todo doesn't point to a issue link, UpdaterFormNoRecommendedReleaseMessageTest.php : line 94
   

   // @todo Use \Drupal\Tests\WebAssert::statusMessageContains() when module
       //   drops support for Drupal core 9.3.x.

I think we could just fix #16.3 now, then, since we no longer support Drupal 9.

reviewing

Now that 📌 Move Cron Updater form_alter from deperecated test module to automatic_updates Closed: duplicate is closed I will update the todo that has this issues' link.

Setting to needs work for some questions that need answering + a merge leftover but overall this looks pretty good, nice work 🤗.

Also i think it's a good time to pull 📌 Create test trait to set update_test module settings Fixed into sprint ?

Just 1 question For @phenaproxima, everything else looks great.

I went through all the files in the MR and confirmed that all the todos make sense. Thanks for doing this exhaustive research and diligent work!

The only outstanding parts are three things that were flat-out removed. I'll go over those with @tedbow to make sure we intended to remove them. But otherwise, I think this looks great.

OK, I looked this over and everything seemed right, confirmed a few outstanding questions with @tedbow, so I think this is good to go. Ship it!

Really glad to get this one in!

Automatically closed - issue fixed for 2 weeks with no activity.