Fix remaining @todos in ComposerPluginsValidatorTest

yash.rode → made their first commit to this issue’s fork.

Need help wtih \Drupal\Tests\package_manager\Kernel\ComposerPluginsValidatorTest::testValidationDuringPreApply with the dataprovider providerSimpleValidCases(). What should be the the value of extra for fake cweagans/composer-patches.

Should we create separate data providers for \Drupal\Tests\package_manager\Kernel\ComposerPluginsValidatorTest::testValidationDuringPreCreate and testValidationDuringPreApply as providerSimpleValidCasesshouldn't have It cannot be installed by Package Manager. for the earlier one and should be there for the later one.

@yash.rode I think we can just add this message in `testValidationDuringPreApply` directly to the validation result.

I have pushed up a fix

Trying to remove other @todo.

Please just mark going forward — I will have reduced capacity for reviews. @tedbow or @phenaproxima can also review! 😊

I have 2 questions for the changes requested.

I have a doubt, what do we want to test in 'one supported composer plugin' dataset?

Agreed with @yash.rode and @phenaproxima in #18.

But that decision seems to have left some stale/obsolete things in the MR 🤓

Removed obsolete lines of code.

I think this looks really, really good -- such a nice, clear test! I think we could streamline a thing, comment another thing...and just explain something else in an MR comment thread.

But otherwise, I really like it.

Looks fantastic. Made a few very minor changes for strictness' sake, but I think this is excellent; it's clean, clear, and tightly scoped. Excellent. I will commit when tests pass.

Automatically closed - issue fixed for 2 weeks with no activity.