- Issue created by @tedbow
- Assigned to kunal.sachdev
- @kunalsachdev opened merge request.
- 🇧🇪Belgium wim leers Ghent 🇧🇪🇪🇺
The scope of this issue is not entirely clear to me.
AFAICT the direction that you proposed at #3312960-33: [Needs Discussion] Certain validators should be higher priority and stop further validation → means much of what this issue's title implies would be covered by that? So AFAICT this issue's scope is broader: it's saying that in case of
composer validate
failing, we should not even bother continuing?If that's the case, doesn't that mean that 📌 Create an API for base requirement validators which run before other validators and stop event propagation if they fail Fixed becomes obsolete? 🤔 (Other than re-running
composer validate
to be absolutely certain, but that seems pointless?) - 🇺🇸United States phenaproxima Massachusetts
Re #5: I don't think this is broader than 📌 Create an API for base requirement validators which run before other validators and stop event propagation if they fail Fixed .
All this would do is ensure that any public methods of ComposerInspector are running from a sane state. It would not account for other conditions not related to Composer (like whether we have enough disk space, are in a multisite, Packgae Manager disabled by an environment variable, etc.) All of that would be covered by the other issue.
I'm re-titling for clarity.
- Assigned to tedbow
- Status changed to Needs review
over 1 year ago 6:13pm 27 February 2023 - 🇮🇳India rckstr_rohan
Reviewed the latest MR, and found that issue has been fixed, able to validate the composer.
Will move to RTBC done once the tests completes. - Issue was unassigned.
- Status changed to Needs work
over 1 year ago 7:11pm 27 February 2023 - 🇺🇸United States tedbow Ithaca, NY, USA
Looking good, just a couple things
- Status changed to RTBC
over 1 year ago 7:21pm 27 February 2023 -
phenaproxima →
committed d220c954 on 3.0.x authored by
kunal.sachdev →
Issue #3344595 by phenaproxima, kunal.sachdev, tedbow, Wim Leers:...
-
phenaproxima →
committed d220c954 on 3.0.x authored by
kunal.sachdev →
- Status changed to Fixed
over 1 year ago 7:45pm 27 February 2023 Automatically closed - issue fixed for 2 weeks with no activity.