- Issue created by @devkinetic
- @devkinetic opened merge request.
- Status changed to Needs review
almost 2 years ago 1:20am 14 March 2023 - πΊπΈUnited States devkinetic
Moving back to needs work as on subsequent edits of the block, it tries to reset the admin label back to the views default.
- Status changed to Needs work
over 1 year ago 9:37am 5 May 2023 - First commit to issue fork.
- Status changed to Needs review
over 1 year ago 9:40am 5 May 2023 - π§πͺBelgium tim-diels Belgium π§πͺ
You needed to get the label from configuration when set. Adjusted the MR.
- Status changed to RTBC
about 1 year ago 11:34am 13 November 2023 - π§πͺBelgium borisson_ Mechelen, π§πͺ
This change makes sense, looks good to me.
- Status changed to Needs work
12 months ago 3:23pm 27 January 2024 - πͺπΈSpain manuel.adan π
The label field is required, so after the patch, editing existing block instances forces to provide now a title. I think that it could be optional, since create new instances without a label is a admitted situation.
In addition to that, there is another "Title" field when the "Override title" options is enabled, which might cause confusion. Renaming the instance label as "Administrative title" could be a work around for that.
- Status changed to Needs review
9 months ago 11:09pm 23 April 2024 - πΊπΈUnited States smustgrave
Aren't both of those scenarios valid? I see in other block instances the title is required and those that have override title the field that displays is title.
But if it's a blocker can we just add $form['label']['#title'] = $this->t('Admin label'); to the bottom of the change?
- πΊπΈUnited States smustgrave
But MR solves the issue I was seeing. I'm currently using 2 blocks to have the sort filters in the top right and all others in the left column.