- Issue created by @Anybody
- @anybody opened merge request.
- Assigned to thomas.frobieter
- Status changed to Needs work
almost 2 years ago 7:46am 9 March 2023 - π©πͺGermany Anybody Porta Westfalica
@thomas.frobieter: This should be more or less ready! :)
I didn't test it, as setting it up in this state wouldn't make much sense, so please first finish the implementation and then let's have a look again together.
Important to consider:
- [ ] Add css and make it scoped on the widget
- [ ] JS:
Update the JS with your latest code, but only within the START - END.
Note that the functions are internal due to the nesting. If they can not be called, please contact me to rewrite the syntax.
styles
has been renamed consistently tostyleDefinitions
, but please check the console.log first, if it's correctly passed from PHP
The classes-field query selector must be relative to the UI initialized and the UI must be scoped for each paragraph settings form, as of course it should work with * paragraph settings forms opened.
- [ ] PHP:- Define all default styles provided by the module in drowl_paragraphs_styles_ui.module
- The iconPath needs to be provided absolute. See .api.php for examples, when implementing a hook in your theme. But be careful, it's also untested yet!
thomas.frobieter β made their first commit to this issueβs fork.
- Issue was unassigned.
- Status changed to Needs review
almost 2 years ago 2:47pm 9 March 2023 -
Anybody β
committed 3f8d59b7 on 4.x
Issue #3346661: Add drowl_paragraphs_styles_ui complex style selector as...
-
Anybody β
committed 3f8d59b7 on 4.x
- Status changed to Fixed
almost 2 years ago 2:56pm 9 March 2023 - π©πͺGermany Anybody Porta Westfalica
Merged! :)
Nice work @thomas.frobieter! Automatically closed - issue fixed for 2 weeks with no activity.