- 🇺🇸United States papagrande US West Coast
@elber, #4 looks good, but needs a reroll against the 2.0.x branch after I committed your patch from https://www.drupal.org/project/eloqua_api_redux/issues/3340462 📌 Drupal calls should be avoided in classes, use dependency injection instead Fixed .
- Assigned to elber
- Issue was unassigned.
- Status changed to Needs review
almost 2 years ago 11:58am 4 May 2023 - Status changed to Needs work
almost 2 years ago 4:31pm 4 May 2023 - 🇺🇸United States papagrande US West Coast
+++ b/eloqua_api_redux.services.yml @@ -1,7 +1,7 @@ + arguments: ['@config.factory', '@logger.factory', '@http_client_factory']@elber, thank you. #7 almost works, but this needs to be added as you had in patch #4..
- Status changed to Needs review
almost 2 years ago 11:10am 5 May 2023 -
PapaGrande →
committed 31bf3db1 on 2.0.x
Issue #3346028: Make typehint more strict and clearer
-
PapaGrande →
committed 31bf3db1 on 2.0.x
-
PapaGrande →
committed b4e7d748 on 2.0.x authored by
elber →
Issue #3346028 by elber: Removed unused cacheBackend from...
-
PapaGrande →
committed b4e7d748 on 2.0.x authored by
elber →
- Status changed to Fixed
almost 2 years ago 6:42pm 12 May 2023 Automatically closed - issue fixed for 2 weeks with no activity.