Drupal calls should be avoided in classes, use dependency injection instead

@himanshu_jhaloya, I can't see the MR at https://git.drupalcode.org/project/eloqua_api_redux/-/merge_requests/2 without errors. Can you upload a patch for review?

I just added the cacheBackend property, Dependency Injection sounds good to me module keeps working as expected, please revise!

I still can't see any data in the Giltlab merge request--I just see "An error occurred while fetching pending comments". Please attach a patch file that I can review. Thanks.

ok I will work on it.

@elber, thank you very much.

I'm just curious about adding:

+++ b/src/Service/EloquaApiClient.php
@@ -45,6 +53,13 @@ class EloquaApiClient {
+  protected $cacheBackend;

The cache backend never seems to get used in the class so why is it needed? AND if that property wasn't there, why wasn't there an error in __construct() when the property was supposedly being set?

Finally, have you tested the module with and without the patch?

Hi @PapaGrande sorry I will take a look on it and tomorrow I send my feedback!

Hi @PapaGrande you are right I removed the cacheBackend property because it wasn't beeing used in somewhere, please revise.

@elber, thanks! Looks good and passed manual testing.

Automatically closed - issue fixed for 2 weeks with no activity.

PapaGrande → closed merge request !2