Add support for Config Override Inspector

Created on 2 March 2023, over 2 years ago

Problem/Motivation

Config Override Inspector β†’ is a module which tells in the UI whenever a field mapped to a configuration is overridden in a settings file (such as settings.php, settings.local.php, etc.).

Proposed resolution

Add the #config key to all elements corresponding to config keys in the settings form.

✨ Feature request
Status

Active

Version

2.0

Component

General

Created by

πŸ‡§πŸ‡ͺBelgium dieterholvoet Brussels

Live updates comments and jobs are added and updated live.
Sign in to follow issues

Merge Requests

Comments & Activities

  • Issue created by @dieterholvoet
  • Status changed to Needs review over 2 years ago
  • πŸ‡§πŸ‡ͺBelgium dieterholvoet Brussels

    I added all #config keys. I also moved the generation of the webhook hash to an install hook so that it's automatically generated during module install. Otherwise, if hiding the webhook hash field with COI, it would be regenerated every time the settings form loads.

  • πŸ‡¦πŸ‡ΊAustralia dpi Perth, Australia

    Grouping these together for coi and the prime core issue.

  • First commit to issue fork.
  • Open in Jenkins β†’ Open on Drupal.org β†’
    Core: 9.5.5 + Environment: PHP 7.4 & MySQL 5.7
    last update about 1 year ago
    17 pass, 2 fail
  • Status changed to Needs work about 1 year ago
  • πŸ‡ΊπŸ‡ΈUnited States xenophyle

    Looks like WebhookHashTest needs updating since the hash now gets set upon installation.

  • Pipeline finished with Failed
    8 months ago
    Total: 199s
    #365513
  • Pipeline finished with Failed
    8 months ago
    Total: 203s
    #365517
  • Status changed to Needs review 8 months ago
  • πŸ‡§πŸ‡ͺBelgium dieterholvoet Brussels

    I fixed the test. The failing tests are also failing on the dev branch.

  • πŸ‡ΊπŸ‡ΈUnited States xenophyle

    I'm just realizing there is some relationship between COI and core config validation. We plan to eventually support the core config validation and I'm wondering if applying this MR will create any kind of conflict. If we have both "#config" and '#config_target" attributes will that cause any weirdness or is it simply that if your suggestion in πŸ“Œ Use the new #config_target Form API property Active is followed we will need to update the code to remove the "#config"s?

Production build 0.71.5 2024