- Issue created by @Anybody
- Status changed to Needs review
almost 2 years ago 5:22pm 1 March 2023 - @anybody opened merge request.
-
thomas.frobieter →
committed 1d57aa59 on 4.x authored by
Anybody →
Issue #3345294: Image Paragraph lightbox zoom misses to load photoswipe...
-
thomas.frobieter →
committed 1d57aa59 on 4.x authored by
Anybody →
- Status changed to Fixed
almost 2 years ago 5:24pm 1 March 2023 - 🇩🇪Germany Anybody Porta Westfalica
Can not fully work because of: 🐛 Uncaught TypeError: a is undefined Closed: won't fix still it's an improvement, so we'll leave it this way for now.
- Status changed to Needs work
almost 2 years ago 6:48am 2 March 2023 - 🇩🇪Germany Anybody Porta Westfalica
Back to needs work. We'll try to call
\Drupal::service('photoswipe.assets_manager')->attach($attachments);
in a hook instead of adding the library in the template.In Photoswipe v5 that won't be needed anymore, presumably.
- Status changed to Fixed
almost 2 years ago 7:20am 2 March 2023 - 🇩🇪Germany Anybody Porta Westfalica
Nice, this works! With Photoswipe v5 we should be able then to switch back to the more simple implementation. I left a comment for that in code.
Automatically closed - issue fixed for 2 weeks with no activity.