Fix PHP 8.1 deprecation

#3 really seems good.

Let me ask you what do you think about this?

$isPathEmpty = empty($path);
$pathHasWebform = str_contains($path, '/webform/');
$isRequestEmpty = empty($request);
$isQueryStringEmpty = empty($request->getQueryString());

if ($isPathEmpty || !$pathHasWebform || $isRequestEmpty || $isQueryStringEmpty) {
  return $path;
}

Created the MR with this example: https://git.drupalcode.org/project/webform/-/merge_requests/312/diffs

I'd say that technically is the same, but I was reading #Line length and wrapping → and I saw that recommendation there, that seems interesting

With that the conditional is shorter and make the code easier to read. What do you think, makes sense?

thanks jrockowitz but, i applied another patch : https://www.drupal.org/project/webform/issues/3301970 📌 Fix PHP 8.1 deprecation Closed: duplicate
and that makes yours not appliable.

We can simplify the conditions.

    $is_webform_path = (!empty($path) && str_contains($path, '/webform/'));
    $has_query_string = (!empty($request) && !empty($request->getQueryString()));
    if (!$is_webform_path || !$has_query_string) {
      return $path;
    }

Automatically closed - issue fixed for 2 weeks with no activity.