- Issue created by @thomas.frobieter
- Assigned to Anybody
@anybody: Probably install the patch for D9? https://www.drupal.org/project/drupal/issues/3192234#comment-14852035 📌 Apply width and height attributes to allow responsive image tag use loading="lazy" Fixed
- 🇩🇪Germany Anybody Porta Westfalica
Yep, we'll wait for the Drupal 10 📌 Apply width and height attributes to allow responsive image tag use loading="lazy" Fixed fix and see if it's solved with that.
- Issue was unassigned.
- 🇩🇪Germany Anybody Porta Westfalica
We just ran into this issue on our Drupal 10 projects. Reopening!
- 🇩🇪Germany Anybody Porta Westfalica
First needs to be fixed upstream in: 🐛 drupal_image() needs #width / #height values for fully working image cache scale, lazy-loading and img attributes RTBC
- Open on Drupal.org →Core: 10.0.7 + Environment: PHP 8.0 & MySQL 5.7last update
over 1 year ago Waiting for branch to pass - @anybody opened merge request.
- Open on Drupal.org →Core: 10.0.7 + Environment: PHP 8.0 & MySQL 5.7last update
over 1 year ago Waiting for branch to pass - Open on Drupal.org →Core: 10.0.7 + Environment: PHP 8.0 & MySQL 5.7last update
over 1 year ago Waiting for branch to pass - Assigned to thomas.frobieter
- Status changed to Needs review
over 1 year ago 3:10pm 24 April 2023 - 🇩🇪Germany Anybody Porta Westfalica
Okay. Lazy loading is added. Still we found out drupal_image() in twig_tweak has some flaws. For example:
- #alt
- #title
are not provided as parameters and set as attribute values instead of using the theme_image properties. Furthermore
- #width
- #height
are not provided, which leads to missing width / height calculation by image styles in core!
But that's not part of this issue, we should monitor the twig_tweak issues I'll create separately.
Ready for review!
- Open on Drupal.org →Core: 10.0.7 + Environment: PHP 8.0 & MySQL 5.7last update
over 1 year ago Waiting for branch to pass -
thomas.frobieter →
committed d2d1ab2a on 4.x authored by
Anybody →
Issue #3344645 by Anybody: 3344645-all-image-paragraphs-width-height-...
-
thomas.frobieter →
committed d2d1ab2a on 4.x authored by
Anybody →
- Status changed to Fixed
over 1 year ago 3:13pm 24 April 2023 Automatically closed - issue fixed for 2 weeks with no activity.
- Status changed to Fixed
over 1 year ago 11:58am 9 May 2023 - 🇩🇪Germany Anybody Porta Westfalica
Follow-up for twig_tweak: 🐛 drupal_image() needs #width / #height values for fully working image cache scale, lazy-loading and img attributes RTBC