ComposerInspector::validate() should throw ComposerNotReadyException instead of \Exception

Nope, that is changing completely in 📌 Refactor exception architecture Fixed . That should land first.

That issue is introducing class StageException extends \RuntimeException (and removes StageValidationException), so I propose class ActiveException extends \RuntimeException?

That issue is introducing class StageException extends \RuntimeException (and removes StageValidationException), so I propose class ActiveException extends \RuntimeException?

I don't know if that would be the best choice of name, because ComposerInspector::validate() can validate any directory. It may be the active, or it may not. I'd still say ComposerNotReadyException is a clearer name.

WFM! 👍

Actually, given #4, ComposerNotReadyException extends \RuntimeException can absolutely happen now 👍

This is a great start, but I found a few things.

One question for @phenaproxima, but a bunch of actionable feedback for @yash.rode 👍

Per @phenaproxima's feedback.

I think what @phenaproxima is saying, is in favor of me.

It doesn't need to be me who reviews this — I think @phenaproxima will want to review this anyway :)

📌 UnknownPathExcluder should use ComposerInspector instead of ComposerUtility Fixed just landed, which requires this MR to be updated.

Also: the @throws docs need to be updated — see https://git.drupalcode.org/project/automatic_updates/-/merge_requests/75...

I have one question i.e do we want to throw ComposerNotReadyException in \Drupal\package_manager\ComposerInspector::validateExecutable. I think we should throw \Exception and not
ComposerNotReadyException because ComposerNotReadyException it wraps the details such as where the composer command was run and the related exception, but in I think in \Drupal\package_manager\ComposerInspector::validateExecutable we don't run a composer command.

#21, yeah...I think it would make sense to do that.

Ok, so should we change $working_dir in ComposerNotReadyException to be optional because in \Drupal\package_manager\ComposerInspector::validateExecutable() we don't deal with working directory?

Yup! I think that's fine. If the working dir is not passed to ComposerNotReadyException, it means the problem is with Composer itself, not any particular directory.

Looks really good to me.

There a few things to tighten up but nothing serious!

Looks good! Merging when tests pass.

Automatically closed - issue fixed for 2 weeks with no activity.