Add tests for hook_countries_alter()

Quick fix.

We might consider placing uasort after the alter hook, so that countries added through that hook could be sorted.

On the other hand, someone may just want to put some country on top of the list.

This bug proved lack of tests for the country manager.

Should we roll back the previous issue first?

@longwave, I think we can handle it in this issue.

Added test that shows the problem.

Recreated patches

The last submitted patch, 10: core-3344424-10-test-only.patch, failed testing. View results →

Elbonia! Nice test) 👍

Patch failed to apply.

Rerolled test-only patch. Seems like reverting 🐛 Country list is not correctly sorted when it's localized with accents (e.g. German, Turkish) Postponed removed the bug which we are trying to fix here. Test passes and there is no $language_id in ::getList() method anymore.

Maybe we should keep the test itself in core to cover that situation?

🐛 Country list is not correctly sorted when it's localized with accents (e.g. German, Turkish) Postponed has been reverted. So that the patch #2 is no longer needed. However, having a test for this hook is still make sense.

The patch #14 looks good to me.

Good turn, if core gonna remove that hook then ibwtter to have a test

Committed and pushed to 10.1.x, thanks!

Automatically closed - issue fixed for 2 weeks with no activity.