- Issue created by @jmaerckaert
The last submitted patch, 2: 3344223-drupal-10-compatibility-1.patch, failed testing. View results โ
- codesniffer_fixes.patch Interdiff of automated coding standards fixes only.- ๐ฎ๐ณIndia Vishal Choudhary Dharmshala
I have Port this Contrib Module from drupal 9 to drupal 10. Please reviews the code. (I have fixed these issues with the help of the Drupal check command
vendor/mglaman/drupal-check/drupal-check modules/contrib/queue_unique/
Add Screenshots:
Apply Patch Screenshot and Module install in local-D10 Setup Screenshot and Patch file. Please review
Thanks! - Assigned to Vishal Choudhary
- Status changed to Needs work
over 1 year ago 10:24am 28 March 2023 - ๐ฎ๐ณIndia Abhay Sharma
Hi, Vishal I have Applied your Patch File on our local Drupal 10 Setup, And it Working Fine. I think this module is compatible with Drupal 10.
so, I attached the Screenshot of our locally Installed module.
Thanks. - Status changed to RTBC
over 1 year ago 12:42am 26 April 2023 - ๐บ๐ธUnited States moshe weitzman Boston, MA
rtbc based on last comment
- Open on Drupal.org โCore: 9.5.x + Environment: PHP 8.1 & MySQL 8last update
over 1 year ago Not currently mergeable. - @vishal-choudhary opened merge request.
- Status changed to Needs work
over 1 year ago 8:09pm 30 May 2023 - ๐ณ๐ฑNetherlands bbrala Netherlands
+++ b/tests/src/Kernel/UniqueQueueTest.php @@ -144,20 +144,20 @@ class UniqueQueueTest extends KernelTestBase { +/** + * Adds a queue item and stores it directly to the queue. + * + * This code mimics the code that was in UniqueDatabaseQueue::doCreateItem() + * before the update to sha2. + * + * @param string $name + * The queue name. + * @param mixed $data + * Arbitrary data to be associated with the new task in the queue. + * + * @return string|false + * A unique ID if the item was successfully created. False otherwise. + */
This change seems uninstentional, and the indenting is not right here.
The change is small enough, but these comment changes iare not correct.
-
e0ipso โ
committed 2979ac41 on 3.x authored by
Vishal Choudhary โ
Issue #3344223 by Vishal Choudhary, jmaerckaert, Abhay Sharma, moshe...
-
e0ipso โ
committed 2979ac41 on 3.x authored by
Vishal Choudhary โ
- Status changed to Fixed
over 1 year ago 8:23am 31 May 2023 - e0ipso Can Picafort
I merged this. I fixed the indentation of the docblock on commit.
Automatically closed - issue fixed for 2 weeks with no activity.