StateItem::isTransitionAllowed() should only check that the passed transition is allowed

The last submitted patch, 2: 3344193-2.patch, failed testing. View results →

Ok, so I didn't realize that the new workflow method that was made public as part of 🐛 StateItem::isTransitionAllowed() should only check that the passed transition is allowed Fixed doesn't check if the transition is possible, so I documented that.

The code is a little bit less clean with these changes... But considering guards could hold expensive logic, I really don't think it makes sense to invoke them for transitions that the caller doesn't intent to apply... So I still think this is the right thing to do.

Still feeling a bit ambivalent about this, but... still decided to go ahead.

No sure this change is correct.

Why is that? Care to elaborate?

Automatically closed - issue fixed for 2 weeks with no activity.