- Issue created by @alexpott
- Status changed to Needs review
almost 2 years ago 8:56pm 21 February 2023 - ๐ฌ๐งUnited Kingdom alexpott ๐ช๐บ๐
The patch in #2 works nicely...
20:59:48 Directory created at /var/lib/drupalci/workspace/jenkins-drupal_patches-168161/ancillary/container_command.commit-checks 20:59:48 Container command. 20:59:48 core/scripts/dev/commit-code-check.sh --drupalci 21:00:07 1/1 ./scripts/dev/commit-code-check.sh 702.78ms 21:00:08 CSpell: Files checked: 1, Issues found: 0 in 0 files 21:00:08 21:00:08 CSpell: passed
- Status changed to RTBC
almost 2 years ago 9:06pm 21 February 2023 - ๐ซ๐ฎFinland lauriii Finland
Fix is pretty interesting but I think I remember seeing this when working on DrupalCI so itโs a pre-existing thing. Works for me given that tests pass.
- ๐ฌ๐งUnited Kingdom alexpott ๐ช๐บ๐
I've run phpstan, phpcs, cspell, prettier, stylelint, eslint and it is all passing.
-
larowlan โ
committed b7dc1791 on 10.0.x
Issue #3343495 by alexpott: Fix commit-code-check.sh on DrupalCI (...
-
larowlan โ
committed b7dc1791 on 10.0.x
-
larowlan โ
committed 65d49c9c on 10.1.x
Issue #3343495 by alexpott: Fix commit-code-check.sh on DrupalCI
-
larowlan โ
committed 65d49c9c on 10.1.x
-
larowlan โ
committed 846a66c0 on 9.4.x
Issue #3343495 by alexpott: Fix commit-code-check.sh on DrupalCI (...
-
larowlan โ
committed 846a66c0 on 9.4.x
-
larowlan โ
committed d6ef1fa5 on 9.5.x
Issue #3343495 by alexpott: Fix commit-code-check.sh on DrupalCI (...
-
larowlan โ
committed d6ef1fa5 on 9.5.x
- ๐ฆ๐บAustralia larowlan ๐ฆ๐บ๐.au GMT+10
Committed to 10.1.x and backported all the way to 9.4.x
- Status changed to Fixed
almost 2 years ago 3:56am 22 February 2023 - ๐บ๐ธUnited States drumm NY, US
(Updating to resolve Drupal.org issue indexing issue, please disregard.)
- ๐ง๐ชBelgium wim leers Ghent ๐ง๐ช๐ช๐บ
For archeology sake: I discovered & reported this at #3314151-9: Always pass --root to cspell in commit-code-check.sh โ .
- ๐ง๐ชBelgium wim leers Ghent ๐ง๐ช๐ช๐บ
I can't believe @alexpott figured out the correct solution so quickly and @larowlan committed it โฆ all after my late EOD yesterday, meaning that in my new workday, this problem is 100% gone ๐คฉ๐คฏ
Automatically closed - issue fixed for 2 weeks with no activity.