TypeError: Argument 2 passed to Drupal\eca_content\HookHandler::prepareForm() must be of the type string, null given

Thanks @djdevin for reporting this. Had a quick look and it seems that PHP 8.1 with its strict type handling of variables is identifying an issue here that we had not seen before.

The hook from Drupal core is defined like this:

function hook_entity_prepare_form(EntityInterface $entity, $operation, FormStateInterface $form_state)

Our implementation in ECA, however, looks like this:

public function prepareForm(EntityInterface $entity, string $operation, FormStateInterface $form_state)

The small difference is that we declare the string type for the operation argument, as we assumed that an operation is always given. Turns out, that assumption is not correct.

To fix this, we need to go through the code and allow NULL values everywhere the operation is being referenced. Unfortunately, I can't do that today but will get back to this tomorrow - unless somebody else will have jumped in before then and provided a MR to fix this.

Sorry, I should have mentioned this is with PHP 7.4. But it fails on PHP 8.1 too.

$operation is actually NULL being passed in, not sure why yet.

It wasn't quite as bad. @djdevin please give it a try and let us know if that fixes your issue.

Works for me.

Thanks @danielspeicher for your review, I've merged into 1.2 and back ported into 1.1 and 1.0

Automatically closed - issue fixed for 2 weeks with no activity.