- Issue created by @danielkim7755
- @danielkim7755 opened merge request.
- First commit to issue fork.
- 🇺🇸United States joegraduate Arizona, USA
Adding a cache clear step to MigrationFlagsTest::testSyncFlag() allowed the test to pass. The migrate tools module's own sync tests also have cache clear steps that were added as part of the recent change that was included in Migrate Tools 6.0.1 ( 🐛 sync option doesnt work with track_changes Fixed ).
MR should be ready to review now.
- Status changed to Needs review
over 1 year ago 10:49pm 24 April 2023 - 🇺🇸United States trackleft2 Tucson, AZ 🇺🇸
This blocks any site from using this module in Drupal 10, because migrate_tools is not compatible with Drupal 10.
- Status changed to RTBC
over 1 year ago 10:56pm 24 April 2023 - 🇺🇸United States trackleft2 Tucson, AZ 🇺🇸
Please merge into 2.x-dev so that we can test a bit more easily.
For those testing this using Drupal 10, and the corresponding migrate_tools please add the following to your composer.json.
Disclaimer, there may be an issue with migrate_tools version 6.0.1 involving the sync option using Drupal State.
See https://www.drupal.org/project/migrate_tools/issues/3347272 🐛 Migrate sync flag using state API appears to be broken. Needs review - last update
over 1 year ago 10 pass - 🇺🇸United States trackleft2 Tucson, AZ 🇺🇸
While the previous version of this merge request did work, and seemed OK on its face (because you need D10 for migrate_tools and migrate_plus versions 6.0.x) We found a way to allow support for both the 5.x versions and 6.x versions in the same 2.x branch version of migrate_queue_importer, allowing people to wait to upgrade migrate_tools and migrate_plus if they prefer and stay on 9.5.x of Drupal core until the very last minute if they want.
- last update
over 1 year ago 10 pass - @daveiano opened merge request.
- last update
over 1 year ago 5 pass, 3 fail - First commit to issue fork.
- last update
over 1 year ago 10 pass - last update
over 1 year ago 10 pass - 🇩🇪Germany daveiano
First of all, really sorry for not looking earlier into the issue!
Second, thank you all for the work put into this!
I just realized the two branches have the same changes, so the second PR (I created) should be unnecessary. I also added a new test configuration for D10 which fails on the 2.x branch (obviously), because of the conflicting dependencies ( https://www.drupal.org/pift-ci-job/2669301 → ):
Problem 1 - drupal/migrate_tools 5.0.0 requires drupal/core ^8.8 | ^9 -> satisfiable by drupal/core[8.8.0-alpha1, ..., 8.9.x-dev, 9.0.0-alpha1, ..., 9.5.x-dev] from composer repo (https://repo.packagist.org) but drupal/core[10.0.7] from path repo (core) has higher repository priority. The packages from the higher priority repository do not match your constraint and are therefore not installable. That repository is canonical so the lower priority repo's packages are not installable. See https://getcomposer.org/repoprio for details and assistance. - drupal/migrate_tools[5.1.0, ..., 5.x-dev] require drupal/core ^9.1 -> satisfiable by drupal/core[9.1.0-alpha1, ..., 9.5.x-dev] from composer repo (https://repo.packagist.org) but drupal/core[10.0.7] from path repo (core) has higher repository priority. The packages from the higher priority repository do not match your constraint and are therefore not installable. That repository is canonical so the lower priority repo's packages are not installable. See https://getcomposer.org/repoprio for details and assistance. - drupal/migrate_queue_importer 2.x-dev is an alias of drupal/migrate_queue_importer dev-2.x and thus requires it to be installed too. - drupal/migrate_queue_importer dev-2.x requires drupal/migrate_tools ^5.0 -> satisfiable by drupal/migrate_tools[5.0.0, 5.1.0, 5.2.0, 5.x-dev]. - Root composer.json requires drupal/migrate_queue_importer 2.x-dev -> satisfiable by drupal/migrate_queue_importer[2.x-dev (alias of dev-2.x)].
The test is passing now (I updated the
core_version_requirement
on the test modulemigrate_queue_importer_test
) for the MR!So yeah, the version constraints
">=5.0"
allow us to publish this into the 2.x branch of MQI since this is not a breaking change, as @trackleft2 said, this allows for using migrate_tools/migrate_plus 5.x AND 6.x. Tests are now proving this!Will merge this into the 2.x as soon as I can (probably by the end of the week). There will be a new release including this within the next week. Again, @trackleft2 and @joegraduate, thank you very much for the effort!
- last update
over 1 year ago 10 pass - Status changed to Fixed
over 1 year ago 11:11am 19 May 2023 - 🇩🇪Germany daveiano
Merged MR6 into 2.1.x.
2.1.0 will be released within the next week.
You can test the dev release with
composer require 'drupal/migrate_queue_importer:2.1.x-dev@dev'
( https://www.drupal.org/project/migrate_queue_importer/releases/2.1.x-dev → )Thanks again!
Automatically closed - issue fixed for 2 weeks with no activity.