Use short form of the ternary operator when possible

Created on 18 February 2023, over 1 year ago
Updated 20 March 2023, over 1 year ago

This was pointed out in πŸ“Œ Docs and Code improvements, dead code removal, some fixes. Fixed

I would appreciate a review of the entire code base to see if this is the only place that needs to be changed.

πŸ“Œ Task
Status

Fixed

Version

1.0

Component

Code

Created by

πŸ‡ΊπŸ‡ΈUnited States tr Cascadia

Live updates comments and jobs are added and updated live.
Sign in to follow issues

Comments & Activities

Not all content is available!

It's likely this issue predates Contrib.social: some issue and comment data are missing.

  • Issue created by @tr
  • Status changed to Needs review over 1 year ago
  • πŸ‡ΊπŸ‡ΈUnited States tr Cascadia
  • πŸ‡¬πŸ‡§United Kingdom rivimey
  • πŸ‡ΊπŸ‡ΈUnited States tr Cascadia
  • Status changed to RTBC over 1 year ago
  • πŸ‡΅πŸ‡­Philippines paraderojether

    Hi @TR

    I applied patch #2, and it works fine for me. Please look at the screenshot attached.

    Thank You.

  • Status changed to Needs review over 1 year ago
  • πŸ‡ΊπŸ‡ΈUnited States tr Cascadia

    @paraderojether The purpose of posting a patch, like I did in in #2, is to allow DrupalCI (the "testbot") to test the patch. The testbot applies the patch and runs the automated tests, and the results may be seen by clicking on the green box in #2 labeled "PHP 8.1 & MySQL 5.7, D10.1 24 pass". The green color shows that the patch applied cleanly and passed all the tests.

    Because of this, there is absolutely no need to report that the patch can be applied - we already know that. There is no need for screen shots - the test output already shows the patch can be applied. There is also no benefit to that sort of review, because it doesn't tell us anything we don't already know.

    In an issue like this, what is needed is some information that the testbot doesn't provide. For instance, did you try to change the module settings from the modified form after the patch was applied? Were your settings changes saved? Did you review the rest of the code base like I asked to see if there were any other places that need a similar change? I personally found one other place, but I haven't posted a new patch yet. It would help if someone else looked at this to see if there is something I missed.

  • Status changed to Fixed over 1 year ago
  • Automatically closed - issue fixed for 2 weeks with no activity.

Production build 0.71.5 2024