- Issue created by @tr
- πΊπΈUnited States tr Cascadia
Further information:
This hook was added to mimemail 7.x-1.x on 23 Feb 2009 by commit de2aa7fa438ed073da55
There is no issue associated with this commit, so there is no text or documentation to tell us what the intent was. But the commit message is:
- Modifications to mimemail_compress
- added hook_mail_post_process() to mimemail api allowing for message processing after templating has been preformed in mimemail_prepare().An examination of this shows that hook_mail_post_process() was added solely for the benefit of the mimemail_compress submodule.
mimemail_compress is a fork of parts of Emogrifier, but it was removed in the Drupal 8 version of mimemail by π Port mimemail_compress module to D8 Closed: won't fix
A search of the Drupal repository (https://git.drupalcode.org/search?group_id=2&repository_ref=9.5.x&scope=...) shows that this hook is not used by any module other than mimemail_compress.
If we need to recover the functionality of mimemail_compress at some point we can just use the pelago/emogrifier package or the drupal.org/project/emogrifier module - there is no need to write our own version.
- Status changed to Needs review
over 1 year ago 7:22am 8 March 2023 - πΊπΈUnited States tr Cascadia
hook_mail_post_process()
has never worked in Drupal 8+, as it has been commented out since the original port of this module to Drupal 8 back in 2015. See #2138947: Drupal 8 version βBecause of that, and because there have been no requests in the issue queue to restore this hook, and because no one has opened and issue or offered a patch, I conclude that there is no significant desire from the community to support this feature going forward.
Here's a patch that removes the commented-out code.
- Status changed to RTBC
over 1 year ago 2:49am 10 March 2023 - π΅πPhilippines paraderojether
@ TR
Applied patch #3 against Mime Mail version 8.x-1.x-dev with Drupal Core version 9.5.3, and the patch successfully removed the commented-out code.
Thank You.
- Status changed to Fixed
over 1 year ago 12:00am 13 March 2023 Automatically closed - issue fixed for 2 weeks with no activity.