- Issue created by @thomas.frobieter
- 🇩🇪Germany Anybody Porta Westfalica
@thomas.frobieter There doesn't seem to be a specific theme file for videos?
So should we add that attribute programmatically or create a video template in the module?
@anybody thats correct, we've removed most of our video customization stuff, so currently there is no template. If its easier to add this stuff in a template we could add them again .. but yeah.. I think more reliable using the PHP hook.
- 🇩🇪Germany Anybody Porta Westfalica
@thomas.frobieter if you know which attributes to add with which value, please add them as code examples to the issue summary, that will speed things up. If not, someone should do the review sooner or later.
As I think we already have an optional thumbnail image field, that value should be added, if existing. Still we shouldn't make it required.
Generating a thumbnail server-side is depending on server requirements we can't assume. As I think we already have an optional thumbnail image field, that value should be added, if existing. Still we shouldn't make it required.
Generating a thumbnail server-side is depending on server requirements we can't assume.Mhm.. yeah.. we could make that field mandantory, but not that great for the authors. Maybe the best way would be.. allowing Google to generate the thumbnails and only provide a thumbnail, if the Author has uploaded one. Not sure if the Google logic works this way.. but seems .. logical.
So I had a look at this whole.. structured data, video sitemap stuff.. just forget it. Not worth it.
We should simply figure out why the core media video type does not add the poster attribute.
I've added a poster to the core template, to test if this is enough to make the Google Sarch Console happy.. so lets wait for the result.
- 🇩🇪Germany Anybody Porta Westfalica
I think this is the core addition we need, until ✨ Add poster image to HTML5 media videos Needs work we switch to plyr? ( ✨ Allow to select an image field as poster Active )
- Status changed to Postponed
over 1 year ago 1:32pm 4 July 2023 - 🇩🇪Germany Anybody Porta Westfalica
Postponed on ✨ Add poster image to HTML5 media videos Needs work
-
thomas.frobieter →
committed 0b0beb8b on 3.x
Issue #3342696: Add missing poster(-attribute) for media videos
-
thomas.frobieter →
committed 0b0beb8b on 3.x
As a quickfix, I've added template files for the video and remote-video bundles, to prevent the field_image from being printed out.
Otherwise we currently get this, if a preview image is uploaded: