Cannot save settings form after upgrading to 3.x

Created on 17 February 2023, over 1 year ago
Updated 31 October 2023, 8 months ago

Problem/Motivation

I am using Gin admin theme.

I fill out the form then I click the save button, nothing happens.

In my logs I see:
An invalid form control with name='position' is not focusable. <select data-drupal-selector=​"edit-position" id=​"edit-position" name=​"position" class=​"form-select required form-element form-element--type-select" required=​"required" aria-required=​"true" data-drupal-states=​"{"invisible":​{":​input[name=\u0022widget_look\u0022]​":​[{"value":​"float"}​,{"value":​"dropdown_with_flags"}​]​}​}​">​<option value selected=​"selected">​- Select -​</option>​ slot <option value=​"inline">​Inline​</option>​ slot <option value=​"bottom-left">​Bottom left​</option>​ slot <option value=​"bottom-right">​Bottom right​</option>​ slot <option value=​"top-left">​Top left​</option>​ slot <option value=​"top-right">​Top right​</option>​ slot </select>​

Steps to reproduce

Proposed resolution

Remaining tasks

User interface changes

API changes

Data model changes

πŸ› Bug report
Status

Needs work

Version

3.0

Component

Code

Created by

πŸ‡ΊπŸ‡ΈUnited States SocialNicheGuru

Live updates comments and jobs are added and updated live.
Sign in to follow issues

Comments & Activities

  • Issue created by @SocialNicheGuru
  • πŸ‡ΊπŸ‡ΈUnited States utcwebdev

    This problem also occurs in D9.5 Thunder with the Seven Admin (enhanced) theme. Many of the optional settings are hidden by default, but required, so they often prevent saving the settings form.

    For example, if a user were to choose the regular Dropdown that does not include settings for flag icon, size and display options, and attempt to save, the settings cannot be saved. The user must choose among the different display options and set all of the options for all of the optional displays before settings can be saved.

  • πŸ‡¦πŸ‡²Armenia edo888

    Hi,

    Try to reinstall, I believe the default values are not imported during update from older versions.

    Thanks!

  • πŸ‡ΊπŸ‡ΈUnited States SocialNicheGuru

    that was totally it.

    so the update from older versions doesn't quite work.

    Uninstalling and reinstalling does.

  • πŸ‡ΊπŸ‡ΈUnited States SocialNicheGuru

    Not quite sure if this needs an update hook or just an explanation on the module page and Readme.

  • πŸ‡§πŸ‡·Brazil halth Brazil

    Hi everyone! πŸ‘‹

    In my opinion it absolutely needs an update hook for those updating the module. Besides the frustration of facing a WSOD after updating the module, it's bad user experience, which doesn't make justice for such a great module with over 10k users!

    It does deserve a seamless upgrade path to its D10 compatible version.

    I'll try to work on providing an update hook today.

    I'll keep the thread posted.

  • @halth opened merge request.
  • Status changed to Needs review 12 months ago
  • πŸ‡§πŸ‡·Brazil halth Brazil

    Attaching a patch with a temporary, minimal "fix" that will import the default configuration from config/install in a hook update (Also created a MR for it).

    Ideally, we would have a more sophisticated process of copying over the previous configuration entries over to their new names, whenever there's a 1-to-1 match.

    Unfortunately I don't have the time to work on that now.

  • Status changed to Needs work 8 months ago
  • πŸ‡ͺπŸ‡ΈSpain rcodina

    Importing the default config is wrong, the old config must be migrated. This is what is done in πŸ› Errors after upgrading to 3.0.1 from 1.14 or 1.15 Needs work

Production build 0.69.0 2024