- Issue created by @murz
- Assigned to murz
- Merge request !12Issue #3342618: Revisions are not working in Decoupled Router calls using resourceVersion query parameter → (Open) created by murz
- Issue was unassigned.
- Status changed to Needs review
about 2 years ago 9:38am 17 February 2023 - 🇦🇲Armenia murz Yerevan, Armenia
I've extended the RouterPathTranslatorSubscriber to add support for the resourceVersion parameter, please review!
Attaching a static patch file with those changes, to make it possible to use in composer until 🐛 GitLab Merge Requests Unable to Generate Incremental Patch Files Active is resolved.
- 🇦🇲Armenia murz Yerevan, Armenia
I've added a kernel test for this feature, and fixed a cache bug, detected while writing the test :)
- Status changed to Needs work
about 2 years ago 10:07am 19 February 2023 - Status changed to Needs review
about 2 years ago 9:53am 20 February 2023 - 🇦🇲Armenia murz Yerevan, Armenia
I've fixed everything by remarks and have fixed translation support, so please take a look again.
Attaching a static patch file with those changes, to make it possible to use in composer until 🐛 GitLab Merge Requests Unable to Generate Incremental Patch Files Active is resolved.
- 🇺🇦Ukraine goodmood
Re-rolled patch #10 to support upgrade to 2.0.5 version of module
- 🇺🇦Ukraine kovalski.1298
kovalski.1298 → made their first commit to this issue’s fork.
- 🇺🇦Ukraine kovalski.1298
Hi team,
While investigating an issue with /node/123/latest, I came across this ticket. It looks like this route currently resolves to the default revision instead of the latest revision, as the resourceVersion with the latest revision ID is missing.
I've addressed this in the commit linked above—please review.
- 🇺🇦Ukraine kovalski.1298
I’ve completed the implementation of the node/latest route, which allows editors to view their latest changes on the frontend.
However, I’m not sure about the current approach used in this ticket to retrieve a specific entity revision. The issue is that, in theory, a user without permission to view revisions could still use this route to obtain the JSON:API URL of a revision.
I believe that retrieving a specific revision should be handled through the entity.{type}.revision route, which ensures proper access checks. For example, for a node, it should be /node/123/revisions/12345/view, and the user should have a permission like view all revisions.