Cannot remove recurring instance

I found all instances of new Instances(); and replaced it with ClassResolverInterface::getInstanceFromDefinition().

It appears that on the SmartDateOverrideForm, the form_builder service was only being injected to be used as a constructor parameter. Since that was it's only usage and the controller initialization was replaced, I removed the form_builder service from this form class.

This sounds a lot like an issue I encountered while testing the 4.0.x branch. That was documented and a fix committed at 🐛 Fatal Error: missing arguments when using remove instance form Closed: duplicate .

Your proposed code changes look similar to the changes committed in that issue. Can you validate if there's a difference or if that commit could be backported to 3.7.x?

I decided that the changes here are a better approach and more comprehensive than the changes in [#33341820], in addition to being written for 3.7.x. I have reverted the changes there and merged in your patch. Thanks for your work on this!

Automatically closed - issue fixed for 2 weeks with no activity.