- Issue created by @spokje
- @spokje opened merge request.
- @spokje opened merge request.
- Issue was unassigned.
- Status changed to Needs review
almost 2 years ago 10:51am 13 February 2023 - Status changed to Needs work
almost 2 years ago 12:27pm 13 February 2023 The Needs Review Queue Bot → tested this issue. It no longer applies to Drupal core. Therefore, this issue status is now "Needs work".
Apart from a re-roll or rebase, this issue may need more work to address feedback in the issue or MR comments. To progress an issue, incorporate this feedback as part of the process of updating the issue. This helps other contributors to know what is outstanding.
Consult the Drupal Contributor Guide → to find step-by-step guides for working with issues.
- Status changed to Needs review
almost 2 years ago 12:35pm 13 February 2023 - 🇳🇱Netherlands spokje
needs-review-queue-bot
has problems with issue spanning over more than one branch.Telling it to ignore this issue with a friendly no-needs-review-bot tag
- Status changed to RTBC
almost 2 years ago 1:34pm 14 February 2023 - 🇮🇹Italy mondrake 🇮🇹
Looks good to me - probably needs a reroll for the composer lock hash though.
- 🇳🇱Netherlands spokje
Thanks @mondrake, checking for the need of rerolls now.
- 🇳🇱Netherlands spokje
Currently both MRs for 10.0.x and 10.1.x are passing
- Status changed to Needs work
almost 2 years ago 9:12am 17 February 2023 - 🇮🇹Italy mondrake 🇮🇹
Needs a rebase again, and in the meantime PHPStan is at 1.10.1
- First commit to issue fork.
- Status changed to Needs review
over 1 year ago 9:55am 23 February 2023 - 🇬🇧United Kingdom longwave UK
Rebased and updated PHPStan in both branches, didn't regenerate the baseline but will see what failures come out.
- 🇬🇧United Kingdom longwave UK
Pushed baseline updates and a fix to ReverseContainer for both branches.
- Status changed to RTBC
over 1 year ago 1:51pm 23 February 2023 - 🇧🇪Belgium mallezie Loenhout
This looks perfect! Only removal of things, without changing code, thus only removal of false positives.
- Status changed to Needs work
over 1 year ago 2:01pm 23 February 2023 - 🇬🇧United Kingdom catch
Sorry all, this already needs another rebase - committed some other baseline fixes in a different issue this morning :/
If someone pings me after the next rebase I'll insta-commit.
- Status changed to RTBC
over 1 year ago 2:47pm 23 February 2023 - Status changed to Fixed
over 1 year ago 4:18pm 23 February 2023 - 🇬🇧United Kingdom catch
OK this time! Committed/pushed to 10.1.x and 10.0.x respectively, thanks!
Automatically closed - issue fixed for 2 weeks with no activity.