Move migration tests to the Statistics module

In making the fixtures smaller the day count in the \Drupal\Tests\statistics\Kernel\Migrate\d7\MigrateNodeCounterTest::testStatisticsSettings changed for node 4.

The last submitted patch, 2: 3341053-2.patch, failed testing. View results →

Found a few more tests. I don't know what some tests have failed - they pass locally.

The last submitted patch, 4: 3341053-4.patch, failed testing. View results →

Retesting on 11.x

Just after I started the retest I saw why the tests were failing. The patch did not include the test files. This patch adds those.

The last submitted patch, 8: 3341053-8.patch, failed testing. View results →

As usual, update the entity counts. This should pass, so the next step is to reduce the size of the test fixture in the statistics module.

The last submitted patch, 10: 3341053-10.patch, failed testing. View results →

The failing test was unrelated.

It turns out that the fixtures already had a lot of data removed. I did find a few more things to remove and have done so in this patch. There is also a patch without the fixture to make it easier to review the changes.

The last submitted patch, 12: 3341053-12.patch, failed testing. View results →

Hmm. I took too much out of the fixture. Ignore #12 and starting over.

The last submitted patch, 14: 3341053-14.patch, failed testing. View results →

I suspect it is failing because there is no files directory. Adding a dummy file for d6 and d7.

Changes look good and see the todos

Will admit wasn't sure what

$this->assertSame($messages[2]->message, 'Schema errors for block.block.statistics with the following errors: block.block.statistics:settings.top_day_num missing schema, block.block.statistics:settings.top_all_num missing schema, block.block.statistics:settings.top_last_num missing schema');

is testing but see it was done for aggregator which I know was deprecated too.

The last submitted patch, 16: 3341053-16.patch, failed testing. View results →

Changes look good and see the todos

What does 'see the todos' mean?

In any case, I did review the @todo in the patch and found one with an incorrect link. This reroll also fixes that.

The last submitted patch, 19: 3341043-19.patch, failed testing. View results →

Oops, I missed updating entity counts for the D7 Upgrade test.

The last submitted patch, 22: 3341053-22.patch, failed testing. View results →

Reviewed the changes since #17 and URL update makes sense. Which is also RTBC right now.
So guess if that lands this would need to be tweaked.

Rest looks good.

Patch no longer applies, so I rerolled.

The last submitted patch, 26: 3341053-26.patch, failed testing. View results →

Also, update since 📌 Remove use of tour in non profile and update tests Fixed was committed.

Reroll seems good and tests are all green.

The last submitted patch, 28: 3341053-28.patch, failed testing. View results →

The failing test is Drupal\Tests\block\Kernel\Migrate\d6\MigrateBlockTest but it is passing locally on 11.x, so I am retesting.

Tests passing. I am not sure why that test failed today but lets get it retesting. Setting back to RTBC.

The last submitted patch, 28: 3341053-28.patch, failed testing. View results →

Seems to be that same one again. Should a follow up be opened?

The patch in $28 no longer applied so I fixed that and switched to an MR. Also, uploading a diff of the changes.

Reroll seems good.

The Needs Review Queue Bot → tested this issue. It no longer applies to Drupal core. Therefore, this issue status is now "Needs work".

This does not mean that the patch needs to be re-rolled or the MR rebased. Read the Issue Summary, the issue tags and the latest discussion here to determine what needs to be done.

Consult the Drupal Contributor Guide → to find step-by-step guides for working with issues.

Rebased

Rebase seems fine

hiding patches

This needs a re-roll - merge conflicts in MigrateBlockTest

I had no conflicts with the rebase, so I am restoring the RTBC.

Committed/pushed to 11.x, thanks!

Automatically closed - issue fixed for 2 weeks with no activity.

quietone → closed merge request !5257