Fix the issues reported by phpcs

FILE: /Users/kushagra.goyal/Documents/MySites/10.1.x/drupal/modules/contrib/cool_message/cool_message.module -------------------------------------------------------------------------------------------------------------------------------------------- FOUND 14 ERRORS AND 4 WARNINGS AFFECTING 14 LINES -------------------------------------------------------------------------------------------------------------------------------------------- 5 | ERROR | [x] Doc comment short description must start with a capital letter 6 | ERROR | [ ] Doc comment short description must be on a single line, further text should be a separate paragraph 26 | ERROR | [x] Short array syntax must be used to define arrays 27 | ERROR | [x] Short array syntax must be used to define arrays 28 | ERROR | [x] Short array syntax must be used to define arrays 28 | ERROR | [ ] The array declaration extends to column 96 (the limit is 80). The array content should be split up over multiple lines 41 | ERROR | [x] Doc comment long description must end with a full stop 46 | ERROR | [x] Short array syntax must be used to define arrays 56 | ERROR | [x] Whitespace found at end of line 72 | WARNING | [x] There must be no blank line following an inline comment 72 | WARNING | [ ] There must be no blank line following an inline comment 72 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 0 72 | ERROR | [x] 2 spaces found before inline comment; expected "// kint($variables);" but found "// kint($variables);" 77 | ERROR | [x] Whitespace found at end of line 114 | WARNING | [x] A comma should follow the last multiline array item. Found: ) 124 | ERROR | [x] Use null coalesce operator instead of ternary operator. 125 | WARNING | [x] A comma should follow the last multiline array item. Found: $messages 127 | ERROR | [x] Whitespace found at end of line -------------------------------------------------------------------------------------------------------------------------------------------- PHPCBF CAN FIX THE 15 MARKED SNIFF VIOLATIONS AUTOMATICALLY -------------------------------------------------------------------------------------------------------------------------------------------- FILE: /Users/kushagra.goyal/Documents/MySites/10.1.x/drupal/modules/contrib/cool_message/cool_message.routing.yml ----------------------------------------------------------------------------------------------------------------------------------------------------------- FOUND 1 ERROR AND 1 WARNING AFFECTING 2 LINES ----------------------------------------------------------------------------------------------------------------------------------------------------------- 7 | WARNING | [ ] The administration page callback should probably use "administer site configuration" - which implies the user can change something - | | rather than "access administration pages" which is about viewing but not changing configurations. 9 | ERROR | [x] Expected 1 newline at end of file; 0 found ----------------------------------------------------------------------------------------------------------------------------------------------------------- PHPCBF CAN FIX THE 1 MARKED SNIFF VIOLATIONS AUTOMATICALLY ----------------------------------------------------------------------------------------------------------------------------------------------------------- FILE: /Users/kushagra.goyal/Documents/MySites/10.1.x/drupal/modules/contrib/cool_message/cool_message.links.menu.yml ----------------------------------------------------------------------------------------------------------------- FOUND 1 ERROR AFFECTING 1 LINE ----------------------------------------------------------------------------------------------------------------- 6 | ERROR | [x] Expected 1 newline at end of file; 2 found ----------------------------------------------------------------------------------------------------------------- PHPCBF CAN FIX THE 1 MARKED SNIFF VIOLATIONS AUTOMATICALLY ----------------------------------------------------------------------------------------------------------------- FILE: /Users/kushagra.goyal/Documents/MySites/10.1.x/drupal/modules/contrib/cool_message/src/Form/CoolMessage.php ---------------------------------------------------------------------------------------------------------------------- FOUND 1 ERROR AND 2 WARNINGS AFFECTING 3 LINES ---------------------------------------------------------------------------------------------------------------------- 13 | WARNING | [ ] The class short comment should describe what the class does and not simply repeat the class name 82 | ERROR | [x] Expected 1 space after "=>"; 0 found 116 | WARNING | [ ] Possible useless method overriding detected ---------------------------------------------------------------------------------------------------------------------- PHPCBF CAN FIX THE 1 MARKED SNIFF VIOLATIONS AUTOMATICALLY ---------------------------------------------------------------------------------------------------------------------- Time: 104ms; Memory: 10MB

Comments & Activities

Issue created by @kushagra.goyal
Status changed to Needs review almost 2 years ago5:57pm 10 February 2023
Comment almost 2 years ago →
kushagra.goyal
applying a patch to resolve all the PHP coin
Status changed to RTBC almost 2 years ago7:21am 14 February 2023
Comment almost 2 years ago →
🇮🇳India Adil_Siddiqui
Patch reviewed and it is working fine...No phpcs errors encountered.
Comment almost 2 years ago →
🇮🇹Italy apaderno Brescia, 🇮🇹
First commit to issue fork.
Comment over 1 year ago →
🇮🇳India urvashi_vora Madhya Pradesh, India
Tested the patch provided in #2.

Works well and good.

Executed :- "phpcs --standard=Drupal,DrupalPractice --extensions=php,module,inc,install,test,profile,theme,css,js,info,txt,md,yml,twig cool_message-3340954/"

The test result for the patch is : PASS

RTBC++

Committing the changes.
@urvashi_vora opened merge request.

Fix the issues reported by phpcs

Problem/Motivation

Steps to reproduce

Proposed resolution

Comments & Activities