- Issue created by @sidharth_soman
- Status changed to Needs work
over 1 year ago 10:17am 10 February 2023 - 🇮🇳India sidharth_soman Bangalore
Finding the following issues.. I will work on them.
FILE: C:\xampp\htdocs\backendassignment\web\modules\contrib\drush_delete-3340828\src\Commands\DrushDeleteCommands.php --------------------------------------------------------------------------------------------------------------------- FOUND 5 ERRORS AND 2 WARNINGS AFFECTING 7 LINES --------------------------------------------------------------------------------------------------------------------- 1 | ERROR | [x] End of line character is invalid; expected "\n" but found "\r\n" 15 | ERROR | [ ] Missing parameter type 17 | ERROR | [x] Separate the @param and @validate-module-enabled sections by a blank line. 23 | WARNING | [ ] \Drupal calls should be avoided in classes, use dependency injection instead 29 | ERROR | [ ] Missing parameter type 31 | ERROR | [x] Separate the @param and @validate-module-enabled sections by a blank line. 37 | WARNING | [ ] \Drupal calls should be avoided in classes, use dependency injection instead --------------------------------------------------------------------------------------------------------------------- PHPCBF CAN FIX THE 3 MARKED SNIFF VIOLATIONS AUTOMATICALLY --------------------------------------------------------------------------------------------------------------------- FILE: C:\xampp\htdocs\backendassignment\web\modules\contrib\drush_delete-3340828\src\DeleteContent.php ------------------------------------------------------------------------------------------------------ FOUND 1 ERROR AFFECTING 1 LINE ------------------------------------------------------------------------------------------------------ 1 | ERROR | [x] End of line character is invalid; expected "\n" but found "\r\n" ------------------------------------------------------------------------------------------------------ PHPCBF CAN FIX THE 1 MARKED SNIFF VIOLATIONS AUTOMATICALLY ------------------------------------------------------------------------------------------------------ Time: 1.85 secs; Memory: 4MB - Issue was unassigned.
- Status changed to Needs review
over 1 year ago 10:18am 10 February 2023 - 🇮🇳India sidharth_soman Bangalore
All issues except dependency injection are fixed. Please review.
- 🇮🇳India omkar_yewale Mumbai
Patch updated and fixed all the reported issues/warnings, including dependency injection.
- Status changed to RTBC
about 1 year ago 7:19am 17 April 2023 - 🇮🇳India Ashutosh Ahirwal India
Patch #4 applied cleanly.
Moving to RTBC.