Add Tenant entity to Facade module

Created on 9 February 2023, over 1 year ago
Updated 13 February 2023, over 1 year ago

Problem/Motivation

Add Tenant entity to Facade module and its associated CRUD pages.

The entity holds information on launching Cloud Orchestrator using CFn templates.

โœจ Feature request
Status

Fixed

Version

1.0

Component

Code

Created by

๐Ÿ‡บ๐Ÿ‡ธUnited States baldwinlouie

Live updates comments and jobs are added and updated live.
Sign in to follow issues

Comments & Activities

  • Issue created by @baldwinlouie
  • @baldwinlouie opened merge request.
  • Status changed to Needs review over 1 year ago
  • ๐Ÿ‡บ๐Ÿ‡ธUnited States baldwinlouie

    @yas, Please review this patch.

    I decided to use the cloud_config->aws_cloud/k8 entity type to bundle model for Tenant. This way, if we want to have different Tenant types in the future, it is possible. There is a submodule called `tenant_providers/openstack_provider`, which provides the `Openstack Tenant` bundle. The bundle is fieldable.

    1. It adds the Tenant entity. It then adds an entity bundle called `OpenStack`.
    2. Sets up a `Tenant` link in the main menu
    3. It adds any/own permission checking for Tenant entity.
    4. During Tenant creation, I think it is useful to ask for username and email. (We can default it to some other value) This will be sent to CFn to create Cloud Orchestrator. My plan is to not ask for password because we can have Drupal send a `one-time` login link during user creation. The user can then login and update their password.
    5. The Tenant creation form shows a `Region` select box. Right now it doesn't do anything, but it will be used to to determine which regions to create after saving the Tenant.
    6. I've moved the `OpenStack Region` configuration entity into the `openstack_provider` module to keep it implementation specific.

    I don't have an hook_update_N yet, so you will need to uninstall the facade module and re-enable it to get all the new features.

    To use this, the order of operations is
    1. Enable the module
    2. Create your OpenStack Regions
    3. Create the Tenant entities.

  • Status changed to Needs work over 1 year ago
  • ๐Ÿ‡บ๐Ÿ‡ธUnited States yas California ๐Ÿ‡บ๐Ÿ‡ธ

    @baldwinlouie

    Thank you for the update. It looks good, and can you fix the following conding standard error?

    FILE: /var/www/html/web/modules/contrib/facade/README.md
    ----------------------------------------------------------------------
    FOUND 1 ERROR AFFECTING 1 LINE
    ----------------------------------------------------------------------
     1 | ERROR | [x] Expected 1 newline at end of file; 2 found
    ----------------------------------------------------------------------
    PHPCBF CAN FIX THE 1 MARKED SNIFF VIOLATIONS AUTOMATICALLY
    ----------------------------------------------------------------------

    Thanks

  • Status changed to Needs review over 1 year ago
  • ๐Ÿ‡บ๐Ÿ‡ธUnited States baldwinlouie

    @yas, the coding issue has been fixed.

  • ๐Ÿ‡บ๐Ÿ‡ธUnited States yas California ๐Ÿ‡บ๐Ÿ‡ธ

    @baldwinlouie

    Thank you for the update. It looks good, so I'll merge the patch to 4.x and 5.x, and close this issue as Fixed.

  • Status changed to RTBC over 1 year ago
  • Status changed to Fixed over 1 year ago
  • ๐Ÿ‡บ๐Ÿ‡ธUnited States yas California ๐Ÿ‡บ๐Ÿ‡ธ
  • Automatically closed - issue fixed for 2 weeks with no activity.

Production build 0.69.0 2024