- Issue created by @tstoeckler
- 🇩🇪Germany tstoeckler Essen, Germany
I guess this needs a separate patch for 9.5.x when it's committed.
- Status changed to Needs work
almost 2 years ago 9:00pm 8 February 2023 - Status changed to Needs review
almost 2 years ago 4:51am 9 February 2023 - 🇮🇳India mrinalini9 New Delhi
Rerolled patch for the 9.5.x branch, please review it.
Thanks & Regards,
Mrinalini - First commit to issue fork.
- 🇮🇳India rifas-ali-pbi Kerala
I have reviewed the patch and its working fine.
- Status changed to RTBC
almost 2 years ago 12:04pm 13 February 2023 - Status changed to Needs work
almost 2 years ago 1:19pm 13 February 2023 - Status changed to Needs review
almost 2 years ago 1:44pm 13 February 2023 - Status changed to RTBC
almost 2 years ago 9:58am 14 February 2023 - 🇩🇪Germany tstoeckler Essen, Germany
Thanks! I hope it's OK for me to RTBC now that neither of the patches are actually from me.
- Status changed to Needs work
almost 2 years ago 10:07am 14 February 2023 - 🇬🇧United Kingdom catch
I did a gitlab search just in case someone was using this, and it turns out they are:
https://git.drupalcode.org/project/jsonapi_embed/-/blob/8.x-1.x/src/Norm...
That module doesn't appear to be in use/maintained, but I think we need to follow the 'best effort' deprecation policy, and deprecate this in 10.1.x for removal in 11.0.x and then actually remove it there. Doesn't need test coverage, just the @deprecated and a @trigger_error().