Deprecated function: mb_strtolower(): Passing null is deprecated

You should set the issue status to needs review when uploading a patch, more likely to get a review then.

The other changes seem unnecessary as those can't be null imho, and if you get null for pages it means you are missing a config file, it should never be an empty string. I'm open to fixing that one instance, but it can be simplifed, no need to check for empty pages more than once then, just do if ($pages) and the mb_strtolower() inside.

Everything about the error and patch above suggests this should be filed under the project https://www.drupal.org/project/redirect_404 →

There's also a very similar sounding issue for this module that's already been addressed #3252259: Deprecated function: parse_str(): Passing null to parameter #1 ($string) of type string is deprecated in Drupal\redirect\EventSubscriber\RedirectRequestSubscriber->onKernelRequestCheckRedirect →

Closing as dupe. Please file a bug report with the other module if you're still having the issue with that module.

redirect_404 for Drupal 8 is part of this project. And the other issue is about a completely different place.

I fixed the remarks and opened an issue fork. I cannot open the MR right now due to what seems like an infrastructure issue at our Gitlab instance. Uploading patch as well.

Tested patch #7 and approved

Assigning to myself as I'm triaging all RTBC issues.

I've reviewed this issue and the latest patch and see that it only moves the mb_strtolower and there are no other changes that @Berdir requested be removed. It was tested in #8 and this is very simple and tests pass on 9.5 so this looks safe to merge.

Thanks, everyone. This has been merged and will be in the next release.

Automatically closed - issue fixed for 2 weeks with no activity.