- Issue created by @franckylfs
- Status changed to Needs work
almost 2 years ago 7:11am 8 February 2023 - π¦πΊAustralia larowlan π¦πΊπ.au GMT+10
I think we should do this in
\Drupal\link_attributes\LinkAttributesManager::processDefinition
so it is fixed for everywhere rather than just in the widget.If the definition has an 'options' entry (not just for target) we should loop over each item and change it to a TranslatableMarkup object, like is done in
\Drupal\Core\Plugin\Discovery\YamlDiscovery::getDefinitions
We can't use
\Drupal\Core\Plugin\Discovery\YamlDiscovery::addTranslatableProperty
like we do for title, because that only supports string properties. - π¨π¦Canada franckylfs Montreal
Good point. I admit that my solution was too specific. If someone else is willing to do it, go for it. Otherwise, I probably won't have time to edit it for a while. Sorry :(
- First commit to issue fork.
- @izus opened merge request.
- Status changed to Needs review
almost 2 years ago 9:56am 17 February 2023 - π«π·France izus
hi,
as suggested in #4 and #5, here is the merge request : https://git.drupalcode.org/project/link_attributes/-/merge_requests/4
Thanks -
larowlan β
committed 0594bdd2 on 8.x-1.x
Issue #3340073 by FranckyLFS, izus, larowlan: Target options not...
-
larowlan β
committed 0594bdd2 on 8.x-1.x
- Status changed to Fixed
almost 2 years ago 10:28pm 21 February 2023 - π¦πΊAustralia larowlan π¦πΊπ.au GMT+10
Thanks, committed and will cut 8.x-1.13 with this π
Automatically closed - issue fixed for 2 weeks with no activity.