- Issue created by @jwilson3
- 🇩🇪Germany gbyte Berlin
Generally XML sitemaps are not meant to be viewed by humans. You can tell by the fact they themselves are not indexed/included as search results. While this module offers programmatic customizations of XSL output, the default XSL markup is only helpful for debugging purposes and has no effect on the module's intended functionality. Hence not a bug.
I'm happy to review merge requests.
- First commit to issue fork.
- Merge request !56Issue #3340010: Accessibility: "No page regions" in sitemap.xml XSL transform → (Closed) created by duaelfr
- Status changed to Needs review
almost 2 years ago 10:36am 9 February 2023 - Status changed to RTBC
almost 2 years ago 8:12pm 9 February 2023 - 🇪🇨Ecuador jwilson3
Thanks for jumping in @DuaelFr!
I reviewed the MR diff here: https://git.drupalcode.org/project/simple_sitemap/-/merge_requests/56/diffs
At first glance I had my doubts that adding the attribute
role="main"
to<main>
was actually necessary, but in my research, it does appear this is indeed a best practice.Warnings are gone about page regions in WAVE, and the page now has a HEADER, MAIN, and FOOTER regions, as depicted in the attached screenshot.
RTBC.
- Status changed to Fixed
almost 2 years ago 5:20pm 13 March 2023 Automatically closed - issue fixed for 2 weeks with no activity.