- Issue created by @jwilson3
- 🇩🇪Germany gbyte Berlin
Generally XML sitemaps are not meant to be viewed by humans. You can tell by the fact they themselves are not indexed/included as search results. While this module offers programmatic customizations of XSL output, the default XSL markup is only helpful for debugging purposes and has no effect on the module's intended functionality. Hence not a bug.
I'm happy to review merge requests.
- First commit to issue fork.
- Merge request !57Issue #3340008: Accessibility: "Very small text" in sitemap.xml XSL transform → (Closed) created by duaelfr
- Status changed to Needs review
almost 2 years ago 10:48am 9 February 2023 - 🇫🇷France duaelfr Montpellier, France
The MR removes the fixed font-sizes to let them be handled by the browser settings.
Default rendering is now a bit bigger but it's still usable. - Status changed to RTBC
almost 2 years ago 8:18pm 9 February 2023 - 🇪🇨Ecuador jwilson3
Thanks for jumping in @DuaelFr!
I reviewed the MR diff here:
https://git.drupalcode.org/project/simple_sitemap/-/merge_requests/57/diffsCode changes do exactly what is outlined in IS.
Before:
After:
- 🇵🇹Portugal jcnventura
Seeing that the patch is deleting some lines, and making the sitemap.xml MORE accessible, the solution seems perfect.
As @gbyte mentioned in #2, "XML sitemaps are not meant to be viewed by humans", removing a stylesheet definition (which can only be perceived by humans), should not otherwise impact the functionality as it relates to search bots.
RTBC++
- Status changed to Fixed
almost 2 years ago 5:11pm 13 March 2023 Automatically closed - issue fixed for 2 weeks with no activity.